leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 8
Total Committers: 15
Last Commit: 13 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Mar
12:18 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /MsgDefs.h
12:04 pm

Vendor - TEL - Jashwant Gantyada

12:03 pm

Sean Nash and Raghu Kallala

11:59 am

Vendor - TEL - Jashwant Gantyada

done updated below in the function as well.

done updated below in the function as well.

11:59 am

Vendor - TEL - Jashwant Gantyada

done.

done.

11:54 am

Raghu Kallala

Intentional?

Intentional?

11:45 am

Raghu Kallala

update the header and field comments in later commits

update the header and field comments in later commits

10:26 am

Vendor - TEL - Jashwant Gantyada

LDT-1394 updated override request for stroke volume

Options
    • -1
    • +1
    /MsgDefs.h
Thursday 12 Mar
4:32 pm

Sean Nash

4:23 pm

Vendor - TEL - Varshini Nagabooshanam

4:21 pm

Vendor - TEL - Sameer Poyil and Sean Nash

4:21 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
LEAHI-TD-FIRMWARE-LDT-3126_Blood Prime - TD
7:21 am

Raghu Kallala

That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

6:37 am

Raghu Kallala

Updated

Updated

6:37 am

Raghu Kallala

Updated

Updated

6:36 am

Raghu Kallala

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit

6:27 am

Raghu Kallala

You are right, (missed that while duplicating the functions)

You are right, (missed that while duplicating the functions)

Wednesday 11 Mar
2:37 pm

Sean Nash

if ( TRUE == result )

if ( TRUE == result )

2:34 pm

Sean Nash

Since both states require no special handling, remove breaks and group with default - all modes.

Since both states require no special handling, remove breaks and group with default - all modes.

2:34 pm

Sean Nash

Remove comment.

Remove comment.

2:31 pm

Sean Nash

Add comment that all of these states require no special handling.

Add comment that all of these states require no special handling.

2:27 pm

Sean Nash

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

2:25 pm

Sean Nash

Add comment that no action is required for these modes - defaulting to invalid request.

Add comment that no action is required for these modes - defaulting to invalid request.

2:24 pm

Sean Nash

I think this switch should be on requested mode - we haven't changed modes yet.

I think this switch should be on requested mode - we haven't changed modes yet.

2:22 pm

Sean Nash

We have 1 param (and probably should have 2 params - requested mode and submode).

We have 1 param (and probably should have 2 params - requested mode and submode).

2:22 pm

Sean Nash

currentMode is an input.

currentMode is an input.

2:21 pm

Sean Nash

I think this validate function needs to know the requested mode as well - should have 2 params.

I think this validate function needs to know the requested mode as well - should have 2 params.

2:18 pm

Sean Nash

Are we not supporting sub mode requests for these modes?

Are we not supporting sub mode requests for these modes?

2:15 pm

Sean Nash

if ( TRUE == testChangeSubMode )

if ( TRUE == testChangeSubMode )

2:13 pm

Sean Nash

I think these 2 functions are in support of Dialin only, so should be prefixed with "test" as well.

I think these 2 functions are in support of Dialin only, so should be prefixed with "test" as well.