Activity dd-firmware/

5:25 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-1473-1
commented on review

Remove blank line.

5:20 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
replied to Vendor - TEL - Jashwant Gantyada

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

5:17 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Why not "TRUE == "?

5:16 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Why not "TRUE == "?

5:15 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Remove blank line.

5:14 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Remove extra blank line.

5:13 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Outputs in none now I think.

5:12 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
replied to Vendor - TEL - Jashwant Gantyada

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

5:10 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3103-1
commented on review

Why did this file get deleted?

5:03 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Add blank line between declarations and rest of code.

5:02 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3352-1
commented on review

Add comment to right listing which math functions we're using.

3:33 pm

Vendor - TEL - Sameer Poyil

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

3:13 pm

Michael Garthwaite

fixed.

3:12 pm

Michael Garthwaite

reordered and wrapped in a macro

3:12 pm

Michael Garthwaite

see other comment.

3:12 pm

Michael Garthwaite

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

3:11 pm