dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

Remove blank line.

Remove blank line.

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Can you follow up with whoever commented it out and find out if that was intentional? And, if so, will it be coming back? And, if so, should we at least put a TODO on this to restore later?

Why not "TRUE == "?

Why not "TRUE == "?

Why not "TRUE == "?

Why not "TRUE == "?

Remove blank line.

Remove blank line.

Remove extra blank line.

Remove extra blank line.

Outputs in none now I think.

Outputs in none now I think.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Looks like you updated wrong function (the one below instead of this one). It's an output in function below and it's an input in this function.

Why did this file get deleted?

Why did this file get deleted?

Add blank line between declarations and rest of code.

Add blank line between declarations and rest of code.

Add comment to right listing which math functions we're using.

Add comment to right listing which math functions we're using.

It is there in line 131 It would be nice to have it clubbed it together like #ifdef _TEENSY_CONDUCTIVITY_DRIVER_ place all code for teensy here { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSe...

It is there in line 131

It would be nice to have it clubbed it together like

#ifdef _TEENSY_CONDUCTIVITY_DRIVER_
place all code for teensy here

Unknown macro: { MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST, &testSetTeenyConductivityModel }

,
#else
// move the all code under #ifndef _TEENSY_CONDUCTIVITY_DRIVER_ here

#endif

fixed.

fixed.

reordered and wrapped in a macro

reordered and wrapped in a macro

see other comment.

see other comment.

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

reordered MSG IDs such that the teensy specific ones are wrapped in a macro and are far enough in sequence to not cause trouble when we are ready to remove them.

fixed.

fixed.

removed

removed

fixed.

fixed.

it stop gap to see if it was valve specific. Its been reverted.

it stop gap to see if it was valve specific. Its been reverted.

LEAHI-DD-FIRMWARE-LDT-3480_Improper match on IOFP temperature sensors
LEAHI-DD-FIRMWARE-LDT-3480_Improper match on IOFP temperature sensors
LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
LEAHI-DD-FIRMWARE-LDT-3352_DD - revisit D3 level control logic
Looks crucible is not seeing those. let me check once with Dara.

Looks crucible is not seeing those. let me check once with Dara.

Done.

Done.

Updated.

Updated.

Updated

Updated