leahi-common

Clone Tools

Stats

Commits this week: 30
Total Committers: 18
Last Commit: 16 Mar
Commits this week: 30

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Vendor - TEL - Arpita Srivastava

We can delete line 46 and 47 and update line 45 to } TUBE_SET_AUTO_EJECT_STATE_T;

We can delete line 46 and 47 and update line 45 to } TUBE_SET_AUTO_EJECT_STATE_T;

5 mins ago

Vendor - TEL - Arpita Srivastava

add a space between message and )

add a space between message and )

8 mins ago

Vendor - TEL - Arpita Srivastava

Change // to /// for doxygen to catch it.

Change // to /// for doxygen to catch it.

25 mins ago

Vendor - TEL - Arpita Srivastava

Can we remove the parameter and switch directly over currentPostTreatmentState?

Can we remove the parameter and switch directly over currentPostTreatmentState?

26 mins ago

Vinayakam Mani

Do we need D48 speed udpate for BCswitch only status?

Do we need D48 speed udpate for BCswitch only status?

35 mins ago

Vendor - TEL - Arpita Srivastava

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

36 mins ago

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

49 mins ago

Sean Nash

I prefer you create a local BOOL result so you can have a simpler return statement.

I prefer you create a local BOOL result so you can have a simpler return statement.

50 mins ago

Sean Nash

Should go to your new complete state here.

Should go to your new complete state here.

57 mins ago

Vendor - TEL - Arpita Srivastava

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

Monday 04 May
4:30 pm

Sean Nash

check alarm status instead of switch state.

check alarm status instead of switch state.

4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

11:04 am

Vendor - TEL - Varshini Nagabooshanam

Uncommented

Uncommented

9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

12:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

Sunday 03 May
11:59 pm

Sean Nash

Why is this service prefixed with "Tx"? Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

11:57 pm

Sean Nash

DrySelfTests unit.

DrySelfTests unit.

11:57 pm

Sean Nash

DrySelfTests unit initialized.

DrySelfTests unit initialized.

11:56 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:55 pm

Sean Nash

.. handles dry self-tests execution for pre-treatment and treatment modes.

.. handles dry self-tests execution for pre-treatment and treatment modes.

11:54 pm

Sean Nash

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

Should be in "", not <>. And should be placed alphabetically down before TxParams.h.

11:52 pm

Sean Nash

Calling signal function here seems circular (that's how we got here in the first place). Shouldn't we set state to the install state here instead?

Calling signal function here seems circular (that's how we got here in the first place).
Shouldn't we set state to the install state here instead?

11:50 pm

Sean Nash

Put before TxParams.

Put before TxParams.

11:50 pm

Sean Nash

I think Praneeth created a function for this. Make sure they're identical.

I think Praneeth created a function for this. Make sure they're identical.

11:46 pm

Sean Nash

11:46 pm

Sean Nash