leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 4
Total Committers: 8
Last Commit: 22 Sep
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Dec
11:25 am

Raghu Kallala

10:43 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:29 am

Raghu Kallala

Resolved

Resolved

10:16 am

Sean Nash

Change comment from 3 to 5 minutes to match code.

Change comment from 3 to 5 minutes to match code.

10:14 am

Sean Nash

I don't see fix

I don't see fix

10:03 am

Raghu Kallala

Fixed the ordering

Fixed the ordering

Friday 05 Dec
3:01 pm

Sean Nash

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

Thursday 04 Dec
10:18 am

Raghu Kallala

Handled in FPOperationModes and respective states of PreGen have it.

Handled in FPOperationModes and respective states of PreGen have it.

10:17 am

Raghu Kallala

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

10:15 am

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

10:14 am

Raghu Kallala

Fixed.

Fixed.

10:11 am

Raghu Kallala

Fixed.

Fixed.

10:10 am

Raghu Kallala

Fixed. thanks

Fixed. thanks

9:00 am

Sean Nash

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

I don't think the number of samples is what you want as 3rd parameter. You want number of bytes so 4 x number of samples so you should pass "sizeof( roRRSamples )".

8:57 am

Sean Nash

Put space between if and ( for all conditions in this function.

Put space between if and ( for all conditions in this function.

8:55 am

Sean Nash

Put first condition in () too.

Put first condition in () too.

Wednesday 03 Dec
5:58 pm

Vendor - TEL - Sameer Poyil

Small letter used

Small letter used

10:38 am

Raghu Kallala

Resolved.

Resolved.

10:34 am

Raghu Kallala

Resolved. Thanks

Resolved. Thanks

8:43 am

Raghu Kallala

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

8:38 am

Raghu Kallala

Published in the respective modules

Published in the respective modules

8:37 am

Raghu Kallala

Done in individual units publish functions.

Done in individual units publish functions.

6:29 am

Vendor - TEL - Sameer Poyil

add any override function if required

add any override function if required

6:28 am

Vendor - TEL - Sameer Poyil

publish filter flush status , add other important data , inlet pressure etc

publish filter flush status , add other important data , inlet pressure etc

6:23 am

Vendor - TEL - Sameer Poyil

do we need override function for high flow rate , low flow rate, conductivity, pressure etc ?

do we need override function for high flow rate , low flow rate, conductivity, pressure etc ?

6:20 am

Vendor - TEL - Sameer Poyil

arrange static and global function properly , public on top and static on bottom

arrange static and global function properly , public on top and static on bottom

6:19 am

Vendor - TEL - Sameer Poyil

Publish all other important data like conductivity and pressures

Publish all other important data like conductivity and pressures

Tuesday 02 Dec
11:43 pm

Vendor - TEL - Sameer Poyil

as a practice , we need to add a pragma pack for all structure irrespective of the size as per Sean.

as a practice , we need to add a pragma pack for all structure irrespective of the size as per Sean.

10:12 am

Raghu Kallala

As everything is of size 32 bits, skipped it

As everything is of size 32 bits, skipped it

8:09 am

Raghu Kallala

Updated.

Updated.