leahi-dialin

leahi_dialin

Clone Tools

Stats

Commits this week: 7
Total Committers: 15
Last Commit: 16 Mar
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

4 hrs ago

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

4 hrs ago

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

4 hrs ago

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

4 hrs ago

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

Sunday 26 Apr
2:46 pm

Sean Nash

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

12:22 pm

Sean Nash

Friday 24 Apr
10:40 am

Zoltan Miskolci

Thursday 23 Apr
11:08 am

Dara Navaei

LEAHI-DIALIN-LDT-4161_Post-Treatment - SW - 01 - TxReview - R&I
LEAHI-DIALIN-LDT-4161_Post-Treatment - SW - 01 - TxReview - R&I
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Wednesday 22 Apr
11:48 am

Raghu Kallala and Michael Garthwaite

Friday 17 Apr
3:05 pm

Nicholas Ramirez

2:43 pm

Behrouz NematiPour

2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

2:24 pm

Behrouz NematiPour

2:23 pm

Tiffany Mejia and Behrouz NematiPour

12:26 pm

Tiffany Mejia and Behrouz NematiPour

12:11 pm

Behrouz NematiPour

12:11 pm

Tiffany Mejia

12:08 pm

Behrouz NematiPour

12:07 pm

Tiffany Mejia

12:07 pm

Behrouz NematiPour

12:05 pm

Dara Navaei

LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
Wednesday 15 Apr
6:18 pm

Sean Nash

3:17 pm

Stephen Quong

12:26 pm

Stephen Quong

12:25 pm

Behrouz NematiPour and Stephen Quong