leahi-dialin / leahi_dialin / td / modules

bubble_detector.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 03 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Friday 30 Jan
11:34 am

Vendor - TEL - Jashwant Gantyada

11:30 am

Zoltan Miskolci

Thursday 29 Jan
1:08 pm

Sean Nash

12:07 pm

Vendor - TEL - Jashwant Gantyada

I see the same implementations for set functions as well. So, I thought it is required and necessary.

I see the same implementations for set functions as well. So, I thought it is required and necessary.

12:06 pm

Vendor - TEL - Jashwant Gantyada

added.

added.

12:06 pm

Vendor - TEL - Jashwant Gantyada

done

done

12:05 pm

Vendor - TEL - Jashwant Gantyada

done

done

12:01 pm

Vendor - TEL - Jashwant Gantyada

LDT-2749 addressed code review comments

Options
    • -6
    • +13
    ./bubble_detector.py
  2. … 1 more file in changeset.
11:01 am

Sean Nash

Remove reset parameter - not an override function.

Remove reset parameter - not an override function.

10:51 am

Sean Nash

Since this isn't an override, is this still appropriate?

Since this isn't an override, is this still appropriate?

10:44 am

Sean Nash

Function needs function header comments (see other functions for example).

Function needs function header comments (see other functions for example).

10:42 am

Sean Nash

Should be ENABLE in this name somewhere.

Should be ENABLE in this name somewhere.

10:41 am

Sean Nash

10:41 am

Sean Nash

10:16 am

Dara Navaei

LEAHI-DIALIN-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
LEAHI-DIALIN-LDT-2749_Ability to Enable Air Bubble Alarm in Standby Mode
10:11 am

Vendor - TEL - Jashwant Gantyada

LDT-2749 Dialin changes for enabling air bubble

Options
    • -0
    • +17
    ./bubble_detector.py
  2. … 1 more file in changeset.
Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -70
    • +39
    ./bubble_detector.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.