leahi-fwcommon

PIControllers.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 8
Last Commit: 15 Jan
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Sean Nash

change flag to tubeSetLeakChecksStarted

change flag to tubeSetLeakChecksStarted

2 mins ago

Sean Nash

Shouldn't this be the pressure sensor normal setup state?

Shouldn't this be the pressure sensor normal setup state?

11 mins ago

Sean Nash

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

initialize start time for next state. Should we set a flag indicating we completed the tube set checks?

18 mins ago

Sean Nash

Call your transition function for new state here.

Call your transition function for new state here.

26 mins ago

Sean Nash

state removed.

state removed.

46 mins ago

Sean Nash

Don't need this flag or this if statement.

Don't need this flag or this if statement.

54 mins ago

Sean Nash

Think about including data.

Think about including data.

55 mins ago

Sean Nash

Needed?

Needed?

57 mins ago

Sean Nash

Still need cmd to barcode reader to scan.

Still need cmd to barcode reader to scan.

58 mins ago

Sean Nash

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

Not a CAN msg to UI. It's a command to barcode reader via fpga. Not implement yet, so TODO comment.

59 mins ago

Sean Nash

remove if statement. No occlusion sensor

remove if statement. No occlusion sensor

1 hr ago

Sean Nash

DrySelfTests

DrySelfTests

1 hr ago

Sean Nash

move to a private publish function.

move to a private publish function.

1 hr ago

Sean Nash

dry self-tests

dry self-tests

1 hr ago

Sean Nash

barcode scan request is made by TD to h/w via fpga. So not needed.

barcode scan request is made by TD to h/w via fpga. So not needed.

2 hrs ago

Vinayakam Mani

Remove this flag.

Remove this flag.

2 hrs ago

Vinayakam Mani

Remove this code.

Remove this code.

3 hrs ago

Vinayakam Mani

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

5 hrs ago

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Monday 04 May
4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

11:04 am

Vendor - TEL - Varshini Nagabooshanam

Uncommented

Uncommented

9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

12:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

Sunday 03 May
11:59 pm

Sean Nash

Why is this service prefixed with "Tx"? Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

Why is this service prefixed with "Tx"?
Also, Praneeth and I agreed to put these state machine services into a sub-folder of Services. See how he did it and do the same.

11:57 pm

Sean Nash

DrySelfTests unit.

DrySelfTests unit.

11:57 pm

Sean Nash

DrySelfTests unit initialized.

DrySelfTests unit initialized.