dd-firmware / firmware / App / Controllers

RinsePump.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 3
Last Commit: 04 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 05 May
12:35 pm

Vinayakam Mani

Remove this flag.

Remove this flag.

12:31 pm

Vinayakam Mani

Remove this code.

Remove this code.

11:57 am

Vinayakam Mani

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

10:20 am

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Monday 04 May
4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Sunday 03 May
11:45 pm

Sean Nash

11:08 pm

Sean Nash

Why are we removing this TODO comment? It looks like we should keep it.

Why are we removing this TODO comment? It looks like we should keep it.

11:06 pm

Sean Nash

Do we need TODO comments to restore these alarms later?

Do we need TODO comments to restore these alarms later?

11:06 pm

Sean Nash

What is the point of this message?

What is the point of this message?

11:01 pm

Sean Nash

Looks like we need a TODO comment to restore these checks later.

Looks like we need a TODO comment to restore these checks later.

Tuesday 28 Apr
12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Sunday 26 Apr
12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Tuesday 21 Apr
9:17 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
Friday 03 Apr
9:31 am

Vendor - TEL - Jashwant Gantyada

8:32 am

Sean Nash

Thursday 02 Apr
3:35 pm

Vinayakam Mani

Tuesday 31 Mar
9:36 am

Sean Nash

Monday 16 Mar
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1
LEAHI-DD-FIRMWARE-LDT-3627_[FP/DD VALVES] The valves sensed state values in the broadcast are always 1
Tuesday 24 Feb
11:55 am

Vendor - TEL - Jashwant Gantyada

10:35 am

Raghu Kallala , Vinayakam Mani and Sean Nash

Monday 23 Feb
1:18 pm

Vendor - TEL - Jashwant Gantyada

LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DD-FIRMWARE-LDT-3344_Firmware support for Beta 2 FPGA updates.
Friday 20 Feb
2:19 pm

Vendor - TEL - Sameer Poyil

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

This is total mess up . that is what I want it a clean implementation. created a ticket LDT-3563 and closing all review comments.

2:17 pm

Vendor - TEL - Sameer Poyil

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

1:42 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

1:42 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.