leahi-fwcommon

Clone Tools

Stats

Commits this week: 7
Total Committers: 12
Last Commit: 11 Feb
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Sean Nash

Only 1 return per function.

Only 1 return per function.

3 hrs ago

Sean Nash

If result is U08, why are we returning U16?

If result is U08, why are we returning U16?

3 hrs ago

Sean Nash

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

3 hrs ago

Sean Nash

Only 1 return statement per function.

Only 1 return statement per function.

3 hrs ago

Sean Nash

Fix alignment of all of the | separators.

Fix alignment of all of the | separators.

3 hrs ago

Sean Nash

This table should be sorted, so this row needs to be moved up now.

This table should be sorted, so this row needs to be moved up now.

3 hrs ago

Sean Nash

Fix alignment.

Fix alignment.

3 hrs ago

Sean Nash

Why remove these functions. All static functions should be prototyped up here.

Why remove these functions. All static functions should be prototyped up here.

3 hrs ago

Sean Nash

S in status should be capitalized.

S in status should be capitalized.

3 hrs ago

Sean Nash

Any reason why pwmInCount can't just be a U32?

Any reason why pwmInCount can't just be a U32?

4 hrs ago

Sean Nash

Do we really need a start state? Can't we just start in off state.

Do we really need a start state? Can't we just start in off state.

4 hrs ago

Sean Nash

Add detail for alarm.

Add detail for alarm.

4 hrs ago

Sean Nash

Remove extra spaces before =.

Remove extra spaces before =.

4 hrs ago

Sean Nash

Don't need #define for zero.

Don't need #define for zero.

4 hrs ago

Sean Nash

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

4 hrs ago

Sean Nash

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

4 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

4 hrs ago

Sean Nash

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

4 hrs ago

Sean Nash

I think we can say none for Outputs.

I think we can say none for Outputs.

4 hrs ago

Sean Nash

I don't see an alarm triggered in this function.

I don't see an alarm triggered in this function.

4 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

4 hrs ago

Sean Nash

We don't need #defines for zero unless zero has some kind of meaning beyond zero.

We don't need #defines for zero unless zero has some kind of meaning beyond zero.

4 hrs ago

Sean Nash

If leak sensor is coming via FPGA, it doesn't belong in GPIO unit. This unit is for GPIO pins on our microprocessor. GPIO pins on FPGA should be gotten using get functions in the FpgaDD unit.

If leak sensor is coming via FPGA, it doesn't belong in GPIO unit. This unit is for GPIO pins on our microprocessor. GPIO pins on FPGA should be gotten using get functions in the FpgaDD unit.

7 hrs ago

Vinayakam Mani

Mask value seems wrong. please update per HDD.

Mask value seems wrong. please update per HDD.

8 hrs ago

Vendor - TEL - Arpita Srivastava

This code review contains known issues, and it is not yet ready for a detailed review.

This code review contains known issues, and it is not yet ready for a detailed review.

8 hrs ago

Vendor - TEL - Jashwant Gantyada

this has already been addressed. I think you have commented on removed code.

this has already been addressed. I think you have commented on removed code.

9 hrs ago

Vendor - TEL - Jashwant Gantyada

added a todo for testing it after we have the new beta 2 units.

added a todo for testing it after we have the new beta 2 units.

9 hrs ago

Vendor - TEL - Jashwant Gantyada

added a todo for testing it after we have the new beta 2 units.

added a todo for testing it after we have the new beta 2 units.

9 hrs ago

Vendor - TEL - Jashwant Gantyada

We will be merging the latest staging and resolve the conflicts after the CR approval.

We will be merging the latest staging and resolve the conflicts after the CR approval.

9 hrs ago

Vendor - TEL - Sameer Poyil

Beta 1.0 and Beta 1.9 , there small difference, please check with Noe if he can re-implement the registers for conductivity in last part.

Beta 1.0 and Beta 1.9 , there small difference, please check with Noe if he can re-implement the registers for conductivity in last part.