drybicart.py

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
merged staging into dry bicart branch and code is pushed

merged staging into dry bicart branch and code is pushed

New code pushed

New code pushed

LDT-2004 -updates for using generic method overrides

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place Broadcast -> cmd_generic_broadcast_interval_override others -> cmd_generic_ov...

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

This is not the code that is currently on staging, so I think you need to update it from there

This is not the code that is currently on staging, so I think you need to update it from there

fixed it

fixed it

LDT-2004 implementing code review comments + test config for drybicart initial fill test in pre-gen

  1. … 1 more file in changeset.
This is a change from Zoltan and I am updated that into my local branch

This is a change from Zoltan and I am updated that into my local branch

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

Add a blank line between functions.

Add a blank line between functions.

Is this staying? Is all of above replacing this class?

Is this staying? Is all of above replacing this class?

Based on the msg id, it should be here

Based on the msg id, it should be here

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

LDT-2004 dialyn updates for drybicart

wrong valve name used , it should be spv

wrong valve name used , it should be spv

LDT-2004 dialin implementation for drybicart statemachines

  1. … 2 more files in changeset.
LDT-2004 dialin update

  1. … 1 more file in changeset.
LDT-2004: dry bicart dialyn implementation

  1. … 2 more files in changeset.
Remove extra blank lines.

Remove extra blank lines.

LDT-2004: dry bicart dialyn implementation