leahi-dialin / leahi_dialin / td / modules

air_pump.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 17 Feb
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Feb
4:46 pm

Zoltan Miskolci

Renamed Air Pump power to Duty Cycle

Options
    • -2
    • +2
    ./air_pump.py
  2. … 1 more file in changeset.
2:49 pm

Dara Navaei

2:49 pm

Dara Navaei

2:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-3554_[TD][Pressure] Data is not loading into Dialin
LEAHI-DIALIN-LDT-3554_[TD][Pressure] Data is not loading into Dialin
Wednesday 11 Feb
12:00 pm

Zoltan Miskolci

11:59 am

Zoltan Miskolci

Merge branch 'LDT-3215-h12_rpm' into staging

Options
    • -7
    • +13
    ./air_pump.py
9:54 am

Raghu Kallala and Michael Garthwaite

9:50 am

Zoltan Miskolci

Tuesday 10 Feb
2:35 pm

Dara Navaei

LEAHI-DIALIN-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
LEAHI-DIALIN-LDT-3215_Measured venous pressure decreases to atmosphere if H12 air pump is dead headed
2:31 pm

Zoltan Miskolci

Added RPM to H12 air pump

Options
    • -7
    • +13
    ./air_pump.py
  2. … 1 more file in changeset.
Friday 06 Feb
10:56 am

Vendor - TEL - Jashwant Gantyada

10:53 am

Zoltan Miskolci and Sean Nash

9:47 am

Vendor - TEL - Jashwant Gantyada

LDT-2316 fixed code review comments

Options
    • -2
    • +1
    ./air_pump.py
9:32 am

Vendor - TEL - Jashwant Gantyada

Done.

Done.

9:31 am

Vendor - TEL - Jashwant Gantyada

LDT-2316 addressed review comments

Options
    • -2
    • +4
    ./air_pump.py
9:26 am

Sean Nash

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

Can we make 255 a constant with a name like MAX_AIR_PUMP_POWER_LEVEL to make it clear what we're doing here?

9:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
LEAHI-DIALIN-LDT-2316_Max allowed H12 power needs to be updated
9:00 am

Vendor - TEL - Jashwant Gantyada

LDT-2316-added fix to accept duty cycle

Options
    • -3
    • +8
    ./air_pump.py
Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -63
    • +40
    ./air_pump.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).

10:46 am

Zoltan Miskolci

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how...

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how much to shift value for it.
Making an alias is more dynamic and not needing separate variables to be maintained for this.