Activity leahi-dialin/leahi_dialin/fp/filtration

6 hrs ago

Sean Nash

More
LEAHI-DIALIN-LDT-2990-1
finished reviewing

1:09 pm

Raghu Kallala and Zoltan Miskolci

More
LEAHI-DIALIN-LDT-2990-1
finished reviewing

2:32 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-2990-1
started review

LEAHI-DIALIN-LDT-2990_IOFP FW and FPGA version request returns None

11:33 am

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-3287-1
finished reviewing

9:10 am

Michael Garthwaite

reverted handler to the original version. This was required to get a merge with develop to work

9:09 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3287-1
commented on review

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete. Please re...

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

3:34 pm

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3287-1
commented on review

Duplicate, please remove

10:51 am

Michael Garthwaite

More
02d624e
changed 2 files
LDT-1840-add_tmp_filtered, LDT-1903-air-trap-level-control---td---0 and 12 more LEAHI-DIALIN-LDT-3287-1

Merge branch 'staging' into LDT-3287-dialin-ability-to-pull-b1.9-iof

- -3
- +3
./filtration_purification.py
- History
- Source
- Diff
./filtration_purification.py
… 1 more file in changeset.

4:20 pm

Sean Nash

More
LEAHI-DIALIN-LDT-3287-1
resumed reviewing

11:48 am

Zoltan Miskolci

11:38 am

Raghu Kallala , Michael Garthwaite and Sean Nash

More
LEAHI-DIALIN-LDT-2787-2
finished reviewing

11:27 am

Zoltan Miskolci

More
bd5420b
changed 2 files
LDT-1840-add_tmp_filtered, LDT-1903-air-trap-level-control---td---0 and 18 more LEAHI-DIALIN-LDT-2787-2 LEAHI-DIALIN-LDT-3287-1

Merge branch 'staging' into LDT-2787-fp_dd_proxy_commands

- -3
- +2
./filtration_purification.py
- History
- Source
- Diff
./filtration_purification.py
… 1 more file in changeset.

10:30 am

Zoltan Miskolci

More
66ca4d7
changed 3 files
LDT-1840-add_tmp_filtered, LDT-1903-air-trap-level-control---td---0 and 18 more LEAHI-DIALIN-LDT-2004-1 LEAHI-DIALIN-LDT-2787-2

testconfig fix

- -2
- +2
./filtration_purification.py
- History
- Source
- Diff
./filtration_purification.py
… 2 more files in changeset.

9:19 am

Michael Garthwaite

More
b9e9c44
changed 3 files
LDT-1840-add_tmp_filtered, LDT-1903-air-trap-level-control---td---0 and 12 more LEAHI-DIALIN-LDT-3287-1

LDT-3287: Reworked the initial message to be a login command instead of a blank ACK message

- -10
- +3
./filtration_purification.py
- History
- Source
- Diff
./filtration_purification.py
… 2 more files in changeset.

9:17 am

Zoltan Miskolci

1:26 pm

Michael Garthwaite

More
1ca6328
changed 3 files
LDT-1840-add_tmp_filtered, LDT-1903-air-trap-level-control---td---0 and 12 more LEAHI-DIALIN-LDT-3287-1

WIP on develop

LDT-3287: added message sent for TD. trimmed documentation

- -2
- +2
./filtration_purification.py
- History
- Source
- Diff
./filtration_purification.py
… 2 more files in changeset.

11:32 am

Dara Navaei

More
LEAHI-DIALIN-LDT-3287-1
started review

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0

11:27 am

Michael Garthwaite

More
2c75906
changed 2 files
LDT-1840-add_tmp_filtered, LDT-1903-air-trap-level-control---td---0 and 12 more LEAHI-DIALIN-LDT-3287-1

LDT-3287: Added an initial message that is sent on class object construction for FP & DD to allow the subsystem to start publishing as the subsystem may assume no one is on the CANbus when dialin is a node.