Activity leahi-dialin/leahi_dialin/common/fp

4:20 pm

Raghu Kallala

More
LEAHI-DIALIN-LDT-3904-1
finished reviewing

10:05 am

Michael Garthwaite

More
LEAHI-DIALIN-LDT-3904-1
finished reviewing

5:09 pm

Zoltan Miskolci

references to Denali has been removed

7:44 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-3904-1
commented on review

Shouldn't we use Leahi instead of Denali?

10:55 am

Zoltan Miskolci

More
9c1ee40
changed 1 file
LDT-3735-non-volatile-memory, LDT-3904-opmode-the-operation-mode-broad and 3 more LEAHI-DIALIN-LDT-3904-1

Updated FP Event list

- -2
- +3
./fp_defs.py
- History
- Source
- Diff
./fp_defs.py

4:07 pm

Zoltan Miskolci

More
27cd8e0
changed 14 files
LDT-3735-non-volatile-memory, LDT-3904-opmode-the-operation-mode-broad and 3 more LEAHI-DIALIN-LDT-3904-1

- Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import to remove cyclic dependencies - Updated alarms

- -1
- +3
./fp_defs.py
- History
- Source
- Diff
./fp_defs.py
… 13 more files in changeset.

5:46 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-3904-1
started review

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes

5:24 pm

Zoltan Miskolci

More
6d104d3
changed 46 files
LDT-3735-non-volatile-memory, LDT-3904-opmode-the-operation-mode-broad and 3 more LEAHI-DIALIN-LDT-3904-1

- Handler and import refactoring of DD module

- -22
- +1
./fp_defs.py
- History
- Source
- Diff
./fp_defs.py
… 45 more files in changeset.

2:23 pm

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-3984-1
commented on review

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am