dd-firmware / firmware / App / Controllers

DryBiCart.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 4
Last Commit: 10 Apr
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Vinayakam Mani

Add a space after and before parenthesis.

Add a space after and before parenthesis.

2 mins ago

Vinayakam Mani

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

7 mins ago

Vinayakam Mani

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

9 mins ago

Vinayakam Mani

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

31 mins ago

Sean Nash

49 mins ago

Sean Nash

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

2 hrs ago

Vendor - TEL - Sameer Poyil

Removing it now. will introduce it later if required

Removing it now. will introduce it later if required

2 hrs ago

Vendor - TEL - Sameer Poyil

will finalize it when ocean spray logic is tested

will finalize it when ocean spray logic is tested

2 hrs ago

Vendor - TEL - Sameer Poyil

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

2 hrs ago

Vendor - TEL - Sameer Poyil

removed

removed

2 hrs ago

Vendor - TEL - Sameer Poyil

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

2 hrs ago

Vendor - TEL - Sameer Poyil

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

2 hrs ago

Vendor - TEL - Sameer Poyil

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

3 hrs ago

Sean Nash

Remove this blank line.

Remove this blank line.

3 hrs ago

Sean Nash

Put () around each of the 2 conditions being ANDed.

Put () around each of the 2 conditions being ANDed.

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

3 hrs ago

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

3 hrs ago

Sean Nash

Should we remove this else if or is it going to be restored later?

Should we remove this else if or is it going to be restored later?

3 hrs ago

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

3 hrs ago

Sean Nash

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

3 hrs ago

Sean Nash

Why do we need this?

Why do we need this?

3 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

3 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

3 hrs ago

Sean Nash

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

4 hrs ago

Sean Nash

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

4 hrs ago

Sean Nash

Let's remove this commented line.

Let's remove this commented line.

6 hrs ago

Vendor - TEL - Sameer Poyil

I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.

7 hrs ago

Vendor - TEL - Sameer Poyil

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals. need to split it or need two message id.

only maximum 30 float data is allowed. If that is the case then I cannot broadcast the acid or bicarb control signals.
need to split it or need two message id.