dd-firmware / firmware / App / Controllers

DryBiCart.c

Clone Tools

Stats

Commits this week: 18
Total Committers: 5
Last Commit: 30 Apr
Commits this week: 18

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
9 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
Thursday 30 Apr
10:06 pm

Vendor - TEL - Sameer Poyil

LDT-3978-midifying drybicart supply upper threshold pressure

Options
    • -1
    • +1
    ./DryBiCart.c
2:23 pm

Vendor - TEL - Sameer Poyil

1:57 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./DryBiCart.c
  2. … 12 more files in changeset.
1:42 pm

Sean Nash

11:17 am

Vendor - TEL - Sameer Poyil

LDT-3978 addressed review comments

Options
    • -2
    • +15
    ./DryBiCart.c
10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:53 am

Vendor - TEL - Sameer Poyil

LDT-3978-addressed review comments

Options
    • -14
    • +24
    ./DryBiCart.c
10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

8:28 am

Vendor - TEL - Sameer Poyil

LDT-3978 fixing compilation warning

Options
    • -1
    • +0
    ./DryBiCart.c
8:25 am

Vendor - TEL - Sameer Poyil

LDT-3978 addressing review comments

Options
    • -55
    • +60
    ./DryBiCart.c
  2. … 1 more file in changeset.
Wednesday 29 Apr
5:41 pm

Vendor - TEL - Sameer Poyil

LDT-3978 fixing compilation error

Options
    • -37
    • +103
    ./DryBiCart.c
  2. … 2 more files in changeset.
1:36 pm

Vendor - TEL - Sameer Poyil

LDT-3978 fix for compilation error

Options
    • -4
    • +6
    ./DryBiCart.c
12:25 pm

Vendor - TEL - Sameer Poyil

12:24 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./DryBiCart.c
12:16 pm

Vendor - TEL - Sameer Poyil

Merge branch LDT-3980-dialysate-composition-dry-bicarb---fw-impl into staging

Options
    • -3
    • +12
    ./DryBiCart.c
12:14 pm

Vinayakam Mani and Sean Nash

11:58 am

Vendor - TEL - Sameer Poyil

LDT-3980 addressed review comments

Options
    • -0
    • +2
    ./DryBiCart.c
10:18 am

Vinayakam Mani

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

Initialize the 'dryBicartPersistantStartTime' back to zero after timeout done, for the next iterations.

4:46 am

Vendor - TEL - Sameer Poyil

LDT-3980 addressed review comments

Options
    • -3
    • +10
    ./DryBiCart.c
Tuesday 28 Apr
9:42 pm

Vendor - TEL - Sameer Poyil

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

Nope. Since we are here after level is LOW (fill request from balancing chamber control state machine) and not filled yet. So level is still LOW

9:30 pm

Vendor - TEL - Sameer Poyil

LDT-3978 firmware implementation for ocean spray

Options
    • -87
    • +77
    ./DryBiCart.c
  2. … 3 more files in changeset.
11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

11:05 am

Vinayakam Mani

Do we need to check if bicarb chamber level is high, ignore opening D80?

Do we need to check if bicarb chamber level is high, ignore opening D80?

11:01 am

Vinayakam Mani

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

This doesn't seem to be correct. Persistence should start once fill complete pressure is achieved, not after D65 opening?

9:17 am

Vinayakam Mani

Align comment

Align comment