leahi-common

Clone Tools

Stats

Commits this week: 21
Total Committers: 20
Last Commit: 27 Apr
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

1 hr ago

Vinayakam Mani

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

1 hr ago

Vinayakam Mani

Remove extra paranthesis.

Remove extra paranthesis.

2 hrs ago

Vinayakam Mani

Remove empty lines

Remove empty lines

2 hrs ago

Vinayakam Mani

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

2 hrs ago

Vinayakam Mani

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Thursday 23 Jul
3:58 pm

Vinayakam Mani

3:39 pm

Vinayakam Mani

LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
2:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:06 pm

Vendor - TEL - Jashwant Gantyada

11:48 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:48 am

Vendor - TEL - Arpita Srivastava

recircPublishTimerCtr is an output

recircPublishTimerCtr is an output

11:46 am

Vendor - TEL - Arpita Srivastava

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

11:44 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:44 am

Dara Navaei

LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
11:40 am

Vendor - TEL - Arpita Srivastava

Initialization missing for the following variables in the init function. startRecircRequested reconnectRequested backToTreatmentRequested resumeRecircRequested

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

11:32 am

Vendor - TEL - Praneeth Bunne

All signal flags are initialized in resetSignalFlags() which we are calling below

All signal flags are initialized in resetSignalFlags() which we are calling below

11:23 am

Vendor - TEL - Arpita Srivastava

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:20 am

Vendor - TEL - Arpita Srivastava

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

11:15 am

Vendor - TEL - Arpita Srivastava

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

11:13 am

Vendor - TEL - Arpita Srivastava

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback

11:07 am

Vendor - TEL - Arpita Srivastava

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

Add @Alarm ALARM_ID_TD_SALINE_BAG_VOLUME_LOW_ALARM

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:05 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:04 am

Vendor - TEL - Arpita Srivastava

Add rinsebackPublishTimerCtr to outputs

Add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

add rinsebackPublishTimerCtr to outputs

add rinsebackPublishTimerCtr to outputs

10:55 am

Vendor - TEL - Arpita Srivastava

break this line

break this line