dd-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 19
Total Committers: 14
Last Commit: 01 May
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 May
12:03 pm

Michael Garthwaite

LDT-4000: fix to levels regarding test config changes

Options
    • -1
    • +1
    ./Level.c
10:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
Thursday 30 Apr
8:50 pm

Michael Garthwaite

LDT-4000: changed beta 2.0 test config to beta 1.9 test config

Options
    • -4
    • +4
    ./Conductivity.c
    • -24
    • +22
    ./Level.c
    • -12
    • +12
    ./Temperature.c
  4. … 3 more files in changeset.
6:40 pm

Michael Garthwaite

LDT-4000: substitution pump implementation and fixes.

Options
    • -6
    • +0
    ./Conductivity.c
  2. … 8 more files in changeset.
2:23 pm

Vendor - TEL - Sameer Poyil

1:57 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Level.c
    • -2
    • +2
    ./Level.h
  3. … 11 more files in changeset.
1:42 pm

Sean Nash

10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

8:49 am

Vendor - TEL - Sameer Poyil

LDT-3978 adreesing review comments

Options
    • -2
    • +2
    ./Level.c
Tuesday 28 Apr
9:30 pm

Vendor - TEL - Sameer Poyil

LDT-3978 firmware implementation for ocean spray

Options
    • -4
    • +4
    ./Level.h
  2. … 3 more files in changeset.
12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

9:20 am

Vendor - TEL - Arpita Srivastava

Monday 27 Apr
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

10:36 am

Vendor - TEL - Sameer Poyil

LDT-3978 fix for conductive level sensor

Options
    • -5
    • +2
    ./Level.c
  2. … 4 more files in changeset.
9:18 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
Sunday 26 Apr
12:45 pm

Sean Nash

12:44 pm

Sean Nash

12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

12:36 pm

Sean Nash

Declare local variables at top of scope.

Declare local variables at top of scope.

12:34 pm

Sean Nash

Add space between ( and ?

Add space between ( and ?

12:33 pm

Sean Nash

Remove blank line.

Remove blank line.

12:31 pm

Sean Nash

Why redeclare result?

Why redeclare result?