Monitors

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-4000: fix to levels regarding test config changes

LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LEAHI-DD-FIRMWARE-LDT-3978_Switch Chamber F conductive level sensors to broadcast 1 as sensing liquid
LDT-4000: changed beta 2.0 test config to beta 1.9 test config

  1. … 3 more files in changeset.
LDT-4000: substitution pump implementation and fixes.

  1. … 8 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 11 more files in changeset.
a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

LDT-3978 adreesing review comments

LDT-3978 firmware implementation for ocean spray

  1. … 3 more files in changeset.
First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Remove space after 'Supply'.

Remove space after 'Supply'.

Align the value declaration indentation.

Align the value declaration indentation.

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

LDT-3978 fix for conductive level sensor

  1. … 4 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Declare local variables at top of scope.

Declare local variables at top of scope.

Add space between ( and ?

Add space between ( and ?

Remove blank line.

Remove blank line.

Why redeclare result?

Why redeclare result?