dd-firmware / firmware / App / Controllers

RinsePump.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 7
Last Commit: 11:57
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Vinayakam Mani

2 hrs ago

Vinayakam Mani

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

2 hrs ago

Vinayakam Mani

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

2 hrs ago

Vinayakam Mani

Substitution pump

Substitution pump

6 hrs ago

Vinayakam Mani

Missing comment.

Missing comment.

6 hrs ago

Vinayakam Mani

update comment. next one as well.

update comment. next one as well.

6 hrs ago

Vinayakam Mani

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

9 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
9 hrs ago

Michael Garthwaite

LDT-4001: fixes and merges from previous working branch.

Options
    • -1
    • +1
    ./RinsePump.c
  2. … 5 more files in changeset.
10 hrs ago

Michael Garthwaite

LDT-4000: changed beta 2.0 test config to beta 1.9 test config

Options
    • -9
    • +4
    ./RinsePump.c
  2. … 5 more files in changeset.
Friday 22 May
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./RinsePump.c
  2. … 18 more files in changeset.
11:11 am

Vendor - TEL - Jashwant Gantyada

10:50 am

Sean Nash and Vinayakam Mani

9:05 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Options
    • -15
    • +24
    ./RinsePump.c
  2. … 1 more file in changeset.
Thursday 21 May
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

Wednesday 20 May
2:30 pm

Raghu Kallala

10:39 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./RinsePump.c
  2. … 5 more files in changeset.
Tuesday 19 May
5:50 pm

Vinayakam Mani and Sean Nash

2:19 pm

Raghu Kallala

Fixed broadcast issue for rinse pump PWM

Options
    • -6
    • +10
    ./RinsePump.c
Monday 18 May
2:59 pm

Raghu Kallala

LDT-4414 added fix to update the pwm value in broadcast and changed setpwm from count to percentage

Options
    • -10
    • +15
    ./RinsePump.c
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.