leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 20
Total Committers: 19
Last Commit: 18 Jun
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jun
10:52 am

Vendor - TEL - Arpita Srivastava

mesage payload is not an input. We correctly mentioned it in the param. Input should be none as we are not reading any global or static variable declared at file level.

mesage payload is not an input. We correctly mentioned it in the param.
Input should be none as we are not reading any global or static variable declared at file level.

10:52 am

Vendor - TEL - Arpita Srivastava

Output should be none as we are not updating any global or static variable declared at file level.

Output should be none as we are not updating any global or static variable declared at file level.

10:49 am

Vendor - TEL - Arpita Srivastava

Please convert the function to have only single point of return. You can assign result = FALSE here. Also check for whitespace characters. Use 4 spaces instead of tab.

Please convert the function to have only single point of return.
You can assign result = FALSE here.

Also check for whitespace characters. Use 4 spaces instead of tab.

10:47 am

Vendor - TEL - Arpita Srivastava

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

10:33 am

Vendor - TEL - Arpita Srivastava

Why are we adding this header here?

Why are we adding this header here?

9:02 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4003_HDF - FW Implementation - 4/4:
LEAHI-TD-FIRMWARE-LDT-4003_HDF - FW Implementation - 4/4:
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Wednesday 17 Jun
12:04 pm

Vendor - TEL - Vijay Pamula

Tuesday 16 Jun
1:24 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

1:16 pm

Vendor - TEL - Jashwant Gantyada

12:41 pm

Michael Garthwaite

11:55 am

Vinayakam Mani

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

10:59 am

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

10:58 am

Vendor - TEL - Jashwant Gantyada

10:44 am

Vinayakam Mani

Remove blank line.

Remove blank line.

10:33 am

Vendor - TEL - Sameer Poyil

I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

10:24 am

Vinayakam Mani

Update name.

Update name.

10:22 am

Vinayakam Mani

Add a Todo comment to resolve the issue.

Add a Todo comment to resolve the issue.

10:20 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:17 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:15 am

Vinayakam Mani

Do we need these comments? delete it if not required.

Do we need these comments? delete it if not required.

10:11 am

Vinayakam Mani

Align the indent

Align the indent

Monday 15 Jun
3:32 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
2:17 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:16 pm

Vinayakam Mani

Remove unused header files.

Remove unused header files.

2:15 pm

Vinayakam Mani

Remove empty line.

Remove empty line.

2:14 pm

Vinayakam Mani

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

2:11 pm

Vinayakam Mani

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

12:29 pm

Vinayakam Mani

Remove the blank line

Remove the blank line

12:28 pm

Vinayakam Mani

Add headers for all below functions.

Add headers for all below functions.