Messaging.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
change accordingly

change accordingly

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

test instead of handle

test instead of handle

Remove extra ;

Remove extra ;

Can we align comments?

Can we align comments?

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

Remove this blank line.

Remove this blank line.

Please typecast alarmID to resolve warning. ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

Please typecast alarmID to resolve warning.

ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Fix merge conflict stuff here.

this function should not return anything.

this function should not return anything.

Please rename all the sPump registers as h10 for consistency.

Please rename all the sPump registers as h10 for consistency.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Add bpMeasurementReady, bpDriverError and pendingBPCommand to outputs.

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Add blank line before return statement.

Add blank line before return statement.

Fixed

Fixed

Added

Added

Fixed

Fixed

Fixed

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Not required here since we are initializing in the main

Yes removed

Yes removed

Fixed

Fixed