TestSupport.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

Remove this blank line.

Remove this blank line.

Align comment.

Align comment.

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

Should this line be un-commented?

Should this line be un-commented?

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

I missed updating this earlier, I’ll push the updated code.

I missed updating this earlier, I’ll push the updated code.

Can't have 3 values. Maximum 2 values allowed.

Can't have 3 values. Maximum 2 values allowed.

Removedd

Removedd

added

added

Updated

Updated

Remove start state.

Remove start state.

Updated

Updated

updated

updated

Yes, removed

Yes, removed

Removed

Removed

yes, removed

yes, removed

Changed

Changed

Removed

Removed

Removed

Removed

Removed

Removed

Added

Added