leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 12
Total Committers: 16
Last Commit: 05 Jun
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Sean Nash

I think p comes before u. Move up one.

I think p comes before u. Move up one.

2 mins ago

Sean Nash

We should initialize BP module from main at startup so we can use it in any mode.

We should initialize BP module from main at startup so we can use it in any mode.

4 mins ago

Sean Nash

I think this should be executed from TaskGeneral so we can do BP things in any mode.

I think this should be executed from TaskGeneral so we can do BP things in any mode.

6 mins ago

Sean Nash

What is "e"? I think this might be a typo and you should put it back the way it was.

What is "e"? I think this might be a typo and you should put it back the way it was.

1 hr ago

Michael Garthwaite

2 hrs ago

Vinayakam Mani and Sean Nash

4 hrs ago

Vendor - TEL - Arpita Srivastava

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

4 hrs ago

Vendor - TEL - Arpita Srivastava

please add blank space between ( (int)postState ), TRUE );

please add blank space between ( (int)postState ), TRUE );

4 hrs ago

Vendor - TEL - Arpita Srivastava

Alarm id should be 196? Description looks same as 194.

Alarm id should be 196?
Description looks same as 194.

5 hrs ago

Michael Garthwaite

fixed thanks

fixed thanks

6 hrs ago

Sean Nash

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

6 hrs ago

Michael Garthwaite

fixed thanks

fixed thanks

6 hrs ago

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

6 hrs ago

Michael Garthwaite

fixed thanks

fixed thanks

6 hrs ago

Michael Garthwaite

this is a set speed in rpm

this is a set speed in rpm

6 hrs ago

Michael Garthwaite

this is speed in rpm

this is speed in rpm

6 hrs ago

Michael Garthwaite

fixed thanks

fixed thanks

6 hrs ago

Michael Garthwaite

fixed thanks

fixed thanks

6 hrs ago

Michael Garthwaite

fixed thanks

fixed thanks

6 hrs ago

Sean Nash

Change speed to rate.

Change speed to rate.

6 hrs ago

Sean Nash

pumpTargetRate

pumpTargetRate

6 hrs ago

Sean Nash

Change function name to say rate instead of speed

Change function name to say rate instead of speed

6 hrs ago

Sean Nash

Is this a rate too?

Is this a rate too?

6 hrs ago

Sean Nash

Is this a rate too?

Is this a rate too?

6 hrs ago

Sean Nash

Change speed to rate.

Change speed to rate.

6 hrs ago

Sean Nash

Is currentPumpSpeed actually a rate?

Is currentPumpSpeed actually a rate?

6 hrs ago

Sean Nash

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is this comment correct? Seems like we're stopping pump if requested to turn off.

6 hrs ago

Sean Nash

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

6 hrs ago

Sean Nash

Align comment.

Align comment.

6 hrs ago

Sean Nash

Align comment. Change "speed" to "rate in comment too. Also, I don't see you initializing these rates.

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.