leahi-common

Clone Tools

Stats

Commits this week: 26
Total Committers: 17
Last Commit: 29 Apr
Commits this week: 26

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
2:23 pm

Vendor - TEL - Sameer Poyil

1:42 pm

Sean Nash

10:58 am

Vendor - TEL - Sameer Poyil

a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

10:41 am

Vinayakam Mani

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

10:40 am

Vinayakam Mani

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

10:32 am

Vinayakam Mani

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

10:30 am

Sean Nash

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

10:26 am

Vinayakam Mani

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?

Wednesday 29 Apr
11:02 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /MsgDefs.h
    • -2
    • +2
    /TDDefs.h
10:59 am

Raghu Kallala

LDT-473 merge latest into staging

Options
10:57 am

Raghu Kallala

10:55 am

Raghu Kallala

LDT-473 merge latest from staging

Options
    • -176
    • +188
    /MsgDefs.h
10:44 am

Vinayakam Mani

Tuesday 28 Apr
6:13 pm

Sean Nash

3:37 pm

Raghu Kallala

LDT-473 removed confirmation as a param

Options
    • -2
    • +1
    /TDDefs.h
2:31 pm

Sean Nash

???

???

2:30 pm

Sean Nash

Do we need a parameter for confirmation?

Do we need a parameter for confirmation?

12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

11:12 am

Vinayakam Mani

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Can we check payload.index is equal to D6_LEVL (instead of above comparision)?

Monday 27 Apr
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

9:18 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
8:07 am

Raghu Kallala

LDT-473 updated tx params payload. Added confirmation field

Options
    • -1
    • +2
    /TDDefs.h
Sunday 26 Apr
3:41 pm

Sean Nash

It looks like you deleted it instead of fixing it.

It looks like you deleted it instead of fixing it.

3:40 pm

Sean Nash

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

3:39 pm

Sean Nash

Need to check heparin bolus volume > 0 too.

Need to check heparin bolus volume > 0 too.

3:38 pm

Sean Nash

Don't we need to check this too still?

Don't we need to check this too still?

3:37 pm

Sean Nash

Do we need to reset authStartTime here before we go to next state?

Do we need to reset authStartTime here before we go to next state?

3:35 pm

Sean Nash

Put positive case first ( TRUE == ...), then alarm and reject cases.

Put positive case first ( TRUE == ...), then alarm and reject cases.