leahi-fwcommon

NVDriver.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 15:15
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 18 Aug
4:46 pm

Vendor - TEL - Suresh Dharnala

4:41 pm

Vinayakam Mani , Sean Nash and Michael Garthwaite

3:48 pm

Sean Nash

This isn't right. Look at staging for correct code.

This isn't right. Look at staging for correct code.

Monday 17 Aug
4:56 pm

Sean Nash

Thursday 13 Aug
11:08 am

Sean Nash

Shouldn't this be in ModePostTreatment?

Shouldn't this be in ModePostTreatment?

11:06 am

Sean Nash

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

10:58 am

Sean Nash

Update this to work for all standby states w/ switch statement on given "new" state.

Update this to work for all standby states w/ switch statement on given "new" state.

10:32 am

Sean Nash

Why zeroes? Why not send TD version constants?

Why zeroes? Why not send TD version constants?

10:22 am

Sean Nash

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

10:16 am

Sean Nash

change enum name too. need 1 alarm for each disinfection type.

change enum name too. need 1 alarm for each disinfection type.

10:14 am

Sean Nash

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

10:06 am

Sean Nash

Missing some disinfects.

Missing some disinfects.

10:05 am

Sean Nash

Move up after HCOL

Move up after HCOL

Thursday 30 Jul
11:23 am

Vendor - TEL - Arpita Srivastava

11:01 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /NVDriver.h
  2. … 3 more files in changeset.
10:23 am

Sean Nash

Wednesday 29 Jul
5:37 pm

Dara Navaei

3:46 pm

Vendor - TEL - Arpita Srivastava

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into LDT-3735-non-volatile-memory

Options
    • -2
    • +5
    /NVDriver.h
  2. … 3 more files in changeset.
3:42 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: TODO: fix in TD

Options
    • -0
    • +44
    /NVDriver.h
  2. … 2 more files in changeset.
11:06 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +5
    /NVDriver.h
  2. … 7 more files in changeset.
Monday 27 Jul
11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Thursday 23 Jul
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?