NVMgmt.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
This isn't right. Look at staging for correct code.

This isn't right. Look at staging for correct code.

Shouldn't this be in ModePostTreatment?

Shouldn't this be in ModePostTreatment?

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

Update this to work for all standby states w/ switch statement on given "new" state.

Update this to work for all standby states w/ switch statement on given "new" state.

Why zeroes? Why not send TD version constants?

Why zeroes? Why not send TD version constants?

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

change enum name too. need 1 alarm for each disinfection type.

change enum name too. need 1 alarm for each disinfection type.

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Missing some disinfects.

Missing some disinfects.

Move up after HCOL

Move up after HCOL

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 3 more files in changeset.
LDT-3735:minor

LDT-375: Minor

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into LDT-3735-non-volatile-memory

  1. … 3 more files in changeset.
LDT-3735: Added one more TODO fix

LDT-3735: TODO: fix in TD

  1. … 2 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 7 more files in changeset.
Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?