td-firmware / firmware / App / Modes

ModePreTreat.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 09 Jul
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 09 Jul
2:07 pm

Sean Nash

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

1:36 pm

Sean Nash

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

Do we really need these setup functions for each state? They all look very simple - just 1 or 2 lines of code.

1:32 pm

Sean Nash

I believe the SyringePump controller will trigger this alarm at end of seek operation.

I believe the SyringePump controller will trigger this alarm at end of seek operation.

1:28 pm

Sean Nash

Syringe pump should already be stopped if preload is done. Do we need to call this here?

Syringe pump should already be stopped if preload is done. Do we need to call this here?

1:24 pm

Sean Nash

This is called from preload state. Not needed here I think.

This is called from preload state. Not needed here I think.

1:22 pm

Sean Nash

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

Don't put comments on function prototypes. Doxygen gets details of functions from the function header.

1:20 pm

Sean Nash

Why (void)?

Why (void)?

1:16 pm

Sean Nash

Where is this being called? Should be called from pre-treatment init I think.

Where is this being called? Should be called from pre-treatment init I think.

1:13 pm

Sean Nash

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

Confirmation signal sounds like a message handler from UI. Message handlers must accept a message as parameter and return BOOL. They must also be added to the message handler table in Messaging.c.

1:11 pm

Sean Nash

Why are we signaling syringe load confirmed here?

Why are we signaling syringe load confirmed here?

1:11 pm

Sean Nash

Do these states need to be public?

Do these states need to be public?

1:08 pm

Sean Nash

Move up one row to alphabetize.

Move up one row to alphabetize.

9:40 am

Vendor - TEL - Vijay Pamula

LDT-4029: Pre-Treatment Heparin Setup State Implementation

Options
    • -1
    • +2
    ./ModePreTreat.h
  2. … 4 more files in changeset.
Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Thursday 02 Jul
1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
Tuesday 30 Jun
1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Monday 22 Jun
9:16 am

Vendor - TEL - Vijay Pamula

Wednesday 17 Jun
12:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePreTreat.h
  2. … 4 more files in changeset.
Friday 12 Jun
11:07 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

5:40 pm

Vinayakam Mani

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

5:39 pm

Vinayakam Mani

Input : Blood pump door status?

Input : Blood pump door status?

5:27 pm

Vinayakam Mani

To be restored?

To be restored?

5:24 pm

Vinayakam Mani

Are these being initialized in the init function?

Are these being initialized in the init function?

5:16 pm

Vinayakam Mani

Need to resolve the merge issues?

Need to resolve the merge issues?

2:13 pm

Vendor - TEL - Vijay Pamula

LDT-4027: Addressed code review comments for pre-treatment recirculate state

Options
    • -1
    • +1
    ./ModePreTreat.h
2:03 pm

Vendor - TEL - Arpita Srivastava

align the comment part

align the comment part

10:45 am

Sean Nash

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now. For now, comment out this line with a TODO to restore when patient connectio...

This is right, but we don't have a patient connection state implemented yet so we will get stuck here if we do this now.
For now, comment out this line with a TODO to restore when patient connection state is implemented and add a temporary line of code to request treatment mode here.

Thursday 11 Jun
10:29 pm

Vendor - TEL - Praneeth Bunne