leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 5
Total Committers: 17
Last Commit: 08 May
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 May
10:48 am

Vendor - TEL - Varshini Nagabooshanam

Removedd

Removedd

10:44 am

Vendor - TEL - Varshini Nagabooshanam

added

added

Tuesday 12 May
8:41 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

3:47 pm

Vendor - TEL - Arpita Srivastava

Add @param section for reasons.

Add @param section for reasons.

3:44 pm

Vendor - TEL - Arpita Srivastava

Please list names of variables in inputs and outputs. You can move any description in the brief section.

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check and break the line in two lines.

Please add a comment for this check and break the line in two lines.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment about this condition check. Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

2:18 pm

Vendor - TEL - Arpita Srivastava

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

2:00 pm

Vendor - TEL - Arpita Srivastava

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

1:59 pm

Vendor - TEL - Arpita Srivastava

Please rename this function to initTreatmentParameters

Please rename this function to initTreatmentParameters

1:58 pm

Vendor - TEL - Arpita Srivastava

We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

1:56 pm

Vendor - TEL - Arpita Srivastava

Even if you do not have an Output, please add the tag with None as the value. Please fix in other functions as well.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

1:54 pm

Vendor - TEL - Arpita Srivastava

Please indent the doxygen comments of all the functions, similar to existing functions.

Please indent the doxygen comments of all the functions, similar to existing functions.

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 11 May
5:41 pm

Vendor - TEL - Arpita Srivastava

origTreatmentParams should be an output?

origTreatmentParams should be an output?

5:39 pm

Vendor - TEL - Arpita Srivastava

Please enclose each condition in parenthesis

Please enclose each condition in parenthesis

5:34 pm

Vendor - TEL - Arpita Srivastava

Can you please move the TODO comment above this line?

Can you please move the TODO comment above this line?

5:32 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check.

Please add a comment for this check.

5:31 pm

Vendor - TEL - Arpita Srivastava

Please add @param

Please add @param

5:29 pm

Vendor - TEL - Arpita Srivastava

Please add @param

Please add @param

5:28 pm

Vendor - TEL - Arpita Srivastava

treatParamsConfirmed should be an output?

treatParamsConfirmed should be an output?

5:25 pm

Vendor - TEL - Arpita Srivastava

Delete extra line

Delete extra line

4:58 pm

Vendor - TEL - Arpita Srivastava

Please assign it to FALSE

Please assign it to FALSE

4:57 pm

Vendor - TEL - Arpita Srivastava

Please add details of you message Id by using this format. @details \b Message \b Sent:

Please add details of you message Id by using this format.

@details \b Message \b Sent:

4:56 pm

Vendor - TEL - Arpita Srivastava

Place add \b before Outputs.

Place add \b before Outputs.

4:55 pm

Vendor - TEL - Arpita Srivastava

Place add \b before Outputs.

Place add \b before Outputs.

11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.