leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
updated

updated

updated in staging

updated in staging

assigned 0.0F as per sameer's suggestion

assigned 0.0F as per sameer's suggestion

defined as suggested

defined as suggested

added accordingly

added accordingly

updated

updated

it was updated in the latest staging

it was updated in the latest staging

updated accordingly

updated accordingly

the variable was renamed and the new ones have 0.0F

the variable was renamed and the new ones have 0.0F

updated

updated

updated

updated

removed

removed

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

No, it isn't. We are going to fault mode on that alarm and Vinay has asked me to comment it out as this needs further testing.

No, it isn't. We are going to fault mode on that alarm and Vinay has asked me to comment it out as this needs further testing.

the function call seems returning U16. Type cast to U32.

the function call seems returning U16. Type cast to U32.

Remove leading space before void.

Remove leading space before void.

Is issue resolved? Can we revert now?

Is issue resolved? Can we revert now?

Also an input I think.

Also an input I think.

keep a blank line between declaration(s) and code.

keep a blank line between declaration(s) and code.

If level can be overridden, you should use get function.

If level can be overridden, you should use get function.

Add blank line before banner.

Add blank line before banner.

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

That's the worst-case timeout decided by team.

That's the worst-case timeout decided by team.

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.