dd-firmware / firmware / App / Monitors

Conductivity.c

Clone Tools

Stats

Commits this week: 6
Total Committers: 7
Last Commit: 25 Jun
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

Add blank line (should be 2 before test support banner).

Add blank line (should be 2 before test support banner).

1 hr ago

Sean Nash

Remove blank line.

Remove blank line.

1 hr ago

Sean Nash

Needs doxygen comments.

Needs doxygen comments.

3 hrs ago

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

6 hrs ago

Michael Garthwaite

fixed. thanks!

fixed. thanks!

6 hrs ago

Michael Garthwaite

fixed. thanks!

fixed. thanks!

6 hrs ago

Michael Garthwaite

fixed. thanks!

fixed. thanks!

6 hrs ago

Michael Garthwaite

fixed. thanks!

fixed. thanks!

6 hrs ago

Michael Garthwaite

Reverted change. Added uncompensated conductivity to the conductivity publishing

Reverted change. Added uncompensated conductivity to the conductivity publishing

8 hrs ago

Vinayakam Mani

space after if.

space after if.

8 hrs ago

Vinayakam Mani

Space after if.

Space after if.

8 hrs ago

Vinayakam Mani

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

If it is useful for current and future conductivity sensor development, you may keep it with TODO comment to remove later once testing is done.

8 hrs ago

Vendor - TEL - Jashwant Gantyada

8 hrs ago

Vendor - TEL - Jashwant Gantyada

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

so, are we removing this? I think it is better to have this as this might make it easier to get and validate the values in future. Not sure what others think.

8 hrs ago

Vinayakam Mani

Remove empty line.

Remove empty line.

8 hrs ago

Vinayakam Mani

Align the indentation

Align the indentation

8 hrs ago

Vinayakam Mani

Align the indentation.

Align the indentation.

Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

9:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:
LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:
Wednesday 24 Jun
2:53 pm

Vendor - TEL - Sameer Poyil

1:02 pm

Vendor - TEL - Sameer Poyil

12:50 pm

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

6:36 am

Raghu Kallala

Tuesday 23 Jun
3:38 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
2:47 pm

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

2:40 pm

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

2:20 pm

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.