DDInterface.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

maybe use target rate for both.

maybe use target rate for both.

Use #define for array size.

Use #define for array size.

Make the 6 a #define

Make the 6 a #define

only 1 return statement

only 1 return statement

remove comma

remove comma

signal functions should return BOOL.

signal functions should return BOOL.

Move up with rest

Move up with rest

Move this function to your service.

Move this function to your service.

Not needed.

Not needed.

Should always exec your bolus sm.

Should always exec your bolus sm.

Keep 2 blank lines before banner

Keep 2 blank lines before banner

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 11 more files in changeset.
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

we don't need pragma alignment on enums, could you exclude it ?

we don't need pragma alignment on enums, could you exclude it ?

Updated to ml/min, except for broadcast in treatment mode

Updated to ml/min, except for broadcast in treatment mode

LDT-4188 converted UF rate to ml per min in all TD modules which interacts with DD. Broadcast is still in L per hr

  1. … 3 more files in changeset.
What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

Changed to U32

Changed to U32

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

LDT-4188 addressed review comments

  1. … 3 more files in changeset.