leahi-common

DDDefs.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 12
Last Commit: 15:58
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vinayakam Mani

align the indent.

align the indent.

6 hrs ago

Vinayakam Mani

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Thursday 14 May
7:21 pm

Vendor - TEL - Sameer Poyil

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

6:02 pm

Vendor - TEL - Sameer Poyil

2:36 pm

Vendor - TEL - Jashwant Gantyada

I had this commented again to push to the develop branch. It is uncommented for my testing.

I had this commented again to push to the develop branch. It is uncommented for my testing.

2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

makes sense. removed it.

1:25 pm

Vendor - TEL - Jashwant Gantyada

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

1:07 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

Monday 11 May
11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.

Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Tuesday 05 May
12:35 pm

Vinayakam Mani

Remove this flag.

Remove this flag.

12:31 pm

Vinayakam Mani

Remove this code.

Remove this code.

11:57 am

Vinayakam Mani

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

10:20 am

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Monday 04 May
4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Sunday 03 May
11:45 pm

Sean Nash

11:08 pm

Sean Nash

Why are we removing this TODO comment? It looks like we should keep it.

Why are we removing this TODO comment? It looks like we should keep it.

11:06 pm

Sean Nash

Do we need TODO comments to restore these alarms later?

Do we need TODO comments to restore these alarms later?