leahi-dialin / leahi_dialin

fp

Clone Tools

Stats

Commits this week: 6
Total Committers: 8
Last Commit: 18 Jun
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jun
4:34 pm

Zoltan Miskolci

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

9:40 am

Michael Garthwaite

9:40 am

Michael Garthwaite

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

9:17 am

Dara Navaei

LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
Tuesday 16 Jun
9:53 am

Zoltan Miskolci

Monday 15 Jun
2:35 pm

Raghu Kallala and Michael Garthwaite

Friday 12 Jun
9:16 am

Dara Navaei

LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request
LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request
Thursday 11 Jun
1:30 pm

Sean Nash

Wednesday 03 Jun
5:02 pm

Dara Navaei

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
Monday 01 Jun
4:20 pm

Zoltan Miskolci

8:01 am

Raghu Kallala

Friday 29 May
10:05 am

Michael Garthwaite

Thursday 21 May
5:09 pm

Zoltan Miskolci

references to Denali has been removed

references to Denali has been removed

11:31 am

Zoltan Miskolci

Removed Denali reference

Options
    • -19
    • +19
    ./filtration_purification.py
    • -9
    • +9
    ./modules/alarms.py
    • -8
    • +8
    ./modules/boost_pump.py
    • -13
    • +13
    ./modules/conductivity_sensors.py
    • -6
    • +6
    ./modules/events.py
    • -9
    • +9
    ./modules/flow_sensors.py
    • -7
    • +7
    ./modules/fp_test_configs.py
    • -6
    • +6
    ./modules/levels.py
    • -4
    • +4
    ./modules/permeate_tank.py
    • -6
    • +6
    ./modules/pressure_sensors.py
    • -8
    • +8
    ./modules/ro_pump.py
    • -6
    • +6
    ./modules/temperatures.py
    • -8
    • +8
    ./modules/valves.py
    • -5
    • +5
    ./modules/water_pumps.py
    • -4
    • +4
    ./proxies/dd_proxy.py
  16. … 61 more files in changeset.
7:44 am

Raghu Kallala

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

Thursday 07 May
10:12 am

Zoltan Miskolci

Added missing data for conversion

Options
    • -8
    • +8
    ./modules/events.py
  2. … 2 more files in changeset.
Wednesday 06 May
5:51 pm

Zoltan Miskolci

Added desc

Options
    • -1
    • +11
    ./modules/events.py
5:45 pm

Zoltan Miskolci

- Updated FP events

Options
    • -94
    • +103
    ./modules/events.py
4:07 pm

Zoltan Miskolci

- Updated Event enum - Updated Datatypes enum - Added some debugging print to abstract class - Removed some init import to remove cyclic dependencies - Updated alarms

Options
    • -25
    • +16
    ./modules/alarms.py
    • -14
    • +13
    ./modules/events.py
    • -1
    • +1
    ./modules/permeate_tank.py
  4. … 11 more files in changeset.
Tuesday 05 May
3:10 pm

Zoltan Miskolci

- Updated events

Options
    • -56
    • +35
    ./modules/events.py
  2. … 3 more files in changeset.
2:25 pm

Zoltan Miskolci

- Updated DD and TD module - Updaterd TDValvePosition enum

Options
    • -56
    • +54
    ./filtration_purification.py
    • -53
    • +52
    ./modules/alarms.py
    • -25
    • +21
    ./modules/boost_pump.py
    • -22
    • +27
    ./modules/conductivity_sensors.py
    • -1
    • +2
    ./modules/events.py
    • -10
    • +14
    ./modules/flow_sensors.py
    • -4
    • +6
    ./modules/fp_test_configs.py
    • -9
    • +14
    ./modules/levels.py
    • -9
    • +12
    ./modules/permeate_tank.py
    • -19
    • +18
    ./modules/pressure_sensors.py
    • -25
    • +22
    ./modules/ro_pump.py
    • -26
    • +23
    ./modules/temperatures.py
    • -7
    • +10
    ./modules/valves.py
    • -4
    • +6
    ./modules/water_pumps.py
    • -2
    • +3
    ./proxies/dd_proxy.py
  16. … 40 more files in changeset.
Monday 04 May
5:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
5:24 pm

Zoltan Miskolci

- DD refactor Changes in FP and TD module

Options
    • -1
    • +2
    ./filtration_purification.py
    • -7
    • +8
    ./modules/alarms.py
    • -3
    • +4
    ./modules/boost_pump.py
    • -3
    • +4
    ./modules/conductivity_sensors.py
    • -17
    • +17
    ./modules/events.py
    • -3
    • +4
    ./modules/flow_sensors.py
    • -4
    • +4
    ./modules/fp_test_configs.py
    • -3
    • +4
    ./modules/levels.py
    • -3
    • +4
    ./modules/permeate_tank.py
    • -3
    • +4
    ./modules/pressure_sensors.py
    • -3
    • +4
    ./modules/ro_pump.py
    • -3
    • +4
    ./modules/temperatures.py
    • -3
    • +4
    ./modules/valves.py
    • -3
    • +3
    ./modules/water_pumps.py
    • -2
    • +2
    ./proxies/dd_proxy.py
  16. … 18 more files in changeset.
Thursday 30 Apr
2:23 pm

Vendor - TEL - Sameer Poyil

Wednesday 29 Apr
12:05 pm

Vendor - TEL - Sameer Poyil

LDT-3984 addressed review comments

Options
    • -1
    • +1
    ./modules/levels.py
Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?