dd-firmware / firmware / App / Drivers

ConductivitySensors.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 8
Last Commit: 05 May
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
10 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Tuesday 05 May
12:35 pm

Vinayakam Mani

Remove this flag.

Remove this flag.

12:31 pm

Vinayakam Mani

Remove this code.

Remove this code.

11:57 am

Vinayakam Mani

Remove this condition to apply the speed for BC switch only as well.

Remove this condition to apply the speed for BC switch only as well.

10:20 am

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

Monday 04 May
4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride

Sunday 03 May
11:45 pm

Sean Nash

11:08 pm

Sean Nash

Why are we removing this TODO comment? It looks like we should keep it.

Why are we removing this TODO comment? It looks like we should keep it.

11:06 pm

Sean Nash

Do we need TODO comments to restore these alarms later?

Do we need TODO comments to restore these alarms later?

11:06 pm

Sean Nash

What is the point of this message?

What is the point of this message?

11:01 pm

Sean Nash

Looks like we need a TODO comment to restore these checks later.

Looks like we need a TODO comment to restore these checks later.

Friday 01 May
11:20 am

Vendor - TEL - Jashwant Gantyada

fixed emrge conflicts and merged LDT-3963

Options
    • -4
    • +4
    ./ConductivitySensors.c
  2. … 3 more files in changeset.
11:04 am

Vendor - TEL - Jashwant Gantyada

LDT-3963 Fixes for beta 2.1 testing

Options
    • -4
    • +4
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
Thursday 30 Apr
8:27 pm

Michael Garthwaite

Merge branch 'LDT-4000-hdf-fw-implementation-1' into develop

Options
    • -1
    • +1
    ./ConductivitySensors.c
  2. … 7 more files in changeset.
6:40 pm

Michael Garthwaite

LDT-4000: substitution pump implementation and fixes.

Options
    • -1
    • +1
    ./ConductivitySensors.c
  2. … 8 more files in changeset.
Tuesday 28 Apr
12:10 pm

Vinayakam Mani

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

First two logics ANDed correct (first cycle and close period). the third one (BC switch only must be ANDed only with close period), not to include first cycle..

Monday 27 Apr
9:18 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DD-FIRMWARE-LDT-4000_HDF - FW Implementation - 1/4:
Sunday 26 Apr
12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Wednesday 22 Apr
10:29 am

Michael Garthwaite

Merge branch 'LDT-3972-water-treatment-and-degassing-1' into develop

Options
    • -5
    • +5
    ./ConductivitySensors.c
Tuesday 21 Apr
9:17 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
LEAHI-DD-FIRMWARE-LDT-3963_Dialysate Flow Rate - FW Implementation - 1/3:
Monday 20 Apr
9:51 am

Dara Navaei

9:26 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ConductivitySensors.c
  2. … 6 more files in changeset.
9:23 am

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

6:52 am

Michael Garthwaite

fixed

fixed

6:52 am

Michael Garthwaite

LDT-3984: code review comments

Options
    • -2
    • +2
    ./ConductivitySensors.c