dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 42
Total Committers: 18
Last Commit: 18 Jun
Commits this week: 42

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Jun
3:18 pm

Vendor - TEL - Sameer Poyil

LDT-4612 drybicart updates

Options
    • -2
    • +2
    ./Controllers/DryBiCart.c
2:34 pm

Vendor - TEL - Sameer Poyil

LDT-4612 persistence on D66 updates

Options
    • -11
    • +8
    ./Controllers/DryBiCart.c
1:53 pm

Vinayakam Mani

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

1:51 pm

Vinayakam Mani

Space after 0

Space after 0

1:48 pm

Vinayakam Mani

prevDryBicartState

prevDryBicartState

1:46 pm

Vinayakam Mani

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

1:31 pm

Vinayakam Mani

prevBalChamberState?

prevBalChamberState?

12:59 pm

Vendor - TEL - Sameer Poyil

LDT-4612 fix for mixing control

Options
    • -2
    • +10
    ./Controllers/MixingControl.c
    • -0
    • +1
    ./Services/Messaging.c
10:21 am

Vendor - TEL - Arpita Srivastava

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

10:11 am

Vendor - TEL - Arpita Srivastava

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

10:06 am

Vendor - TEL - Sameer Poyil

LDT-4409 fix for concentrate pump not running

Options
    • -3
    • +0
    ./Controllers/DryBiCart.c
    • -1
    • +1
    ./Controllers/MixingControl.c
  3. … 1 more file in changeset.
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Wednesday 17 Jun
10:13 pm

Vendor - TEL - Sameer Poyil

LDT-4612 fix for micing control integration issues

Options
    • -21
    • +18
    ./Controllers/DryBiCart.c
    • -3
    • +7
    ./Controllers/MixingControl.c
Tuesday 16 Jun
1:37 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
1:37 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/ConcentratePumps.c
    • -1
    • +1
    ./Controllers/DryBiCart.c
    • -2
    • +2
    ./Controllers/DryBiCart.h
    • -3
    • +3
    ./Controllers/MixingControl.c
    • -4
    • +4
    ./Controllers/MixingControl.h
    • -2
    • +2
    ./Drivers/TemperatureSensors.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
    • -2
    • +2
    ./Modes/ModePreGenDialysate.c
    • -1
    • +1
    ./Monitors/Conductivity.c
    • -2
    • +2
    ./Services/Messaging.c
    • -2
    • +2
    ./Services/TDInterface.c
    • -2
    • +2
    ./Tasks/TaskGeneral.c
    • -2
    • +2
    ./Tasks/TaskPriority.c
1:35 pm

Vendor - TEL - Sameer Poyil

LDT-4409 drybicart and dialysate mixing firmware implementation

Options
    • -2
    • +2
    ./Monitors/Conductivity.c
    • -4
    • +5
    ./Services/Messaging.c
1:24 pm

Vendor - TEL - Jashwant Gantyada and Vinayakam Mani

1:23 pm

Vendor - TEL - Sameer Poyil

LDT-4409 addressed review comments

Options
    • -2
    • +2
    ./Controllers/DryBiCart.c
    • -4
    • +4
    ./Controllers/MixingControl.c
    • -0
    • +3
    ./Controllers/MixingControl.h
    • -2
    • +5
    ./Services/TDInterface.c
1:16 pm

Vendor - TEL - Jashwant Gantyada

12:50 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:49 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Controllers/SubstitutionPump.c
    • -2
    • +2
    ./Drivers/ConductivitySensors.c
    • -1
    • +1
    ./Drivers/ConductivitySensors.h
    • -1
    • +1
    ./Monitors/Conductivity.c
    • -1
    • +1
    ./Monitors/Conductivity.h
    • -1
    • +1
    ./Services/Messaging.c
12:45 pm

Michael Garthwaite

LDT-4485: err fix

Options
    • -0
    • +1
    ./Monitors/Conductivity.c
12:42 pm

Michael Garthwaite

LDT-4485: err fix

Options
    • -1
    • +1
    ./Monitors/Conductivity.c
12:41 pm

Michael Garthwaite

11:55 am

Vinayakam Mani

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

11:17 am

Vendor - TEL - Sameer Poyil

LDT-4409 addressed review comments

Options
    • -0
    • +1
    ./Controllers/MixingControl.c
11:09 am

Vendor - TEL - Sameer Poyil

LDT-4409 addressed review comments

Options
    • -10
    • +4
    ./Controllers/DryBiCart.c
    • -1
    • +0
    ./Controllers/DryBiCart.h
    • -1
    • +1
    ./Controllers/MixingControl.c
    • -1
    • +1
    ./Monitors/Conductivity.c
    • -1
    • +1
    ./Services/TDInterface.c
    • -0
    • +1
    ./Tasks/TaskPriority.c
10:59 am

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

10:58 am

Vendor - TEL - Jashwant Gantyada

10:55 am

Michael Garthwaite

LDT-4485: code review comments

Options
    • -1
    • +0
    ./Controllers/SubstitutionPump.c