leahi-common

Clone Tools

Stats

Commits this week: 17
Total Committers: 14
Last Commit: 04 Feb
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like t...

This doesn't look like a valid substate. We should have an enum for valid substates. In default case, we should trigger a s/w fault and also set the state to a valid state (idle or something like that).

1 hr ago

Sean Nash

I think /// was correct. // will not be seen by doxygen.

I think /// was correct. // will not be seen by doxygen.

3 hrs ago

Vendor - TEL - Sameer Poyil

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

3 hrs ago

Nicholas Ramirez , Behrouz NematiPour and Tiffany Mejia

3 hrs ago

Dara Navaei

LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
3 hrs ago

Vinayakam Mani

Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

4 hrs ago

Vinayakam Mani

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

4 hrs ago

Vinayakam Mani

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

4 hrs ago

Vinayakam Mani

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

4 hrs ago

Vinayakam Mani

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

Wednesday 04 Feb
4:59 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /AlarmDefs.h
    • -1
    • +1
    /DDDefs.h
    • -2
    • +2
    /MsgDefs.h
    • -2
    • +2
    /TDDefs.h
4:57 pm

Vendor - TEL - Varshini Nagabooshanam

4:55 pm

Vendor - TEL - Varshini Nagabooshanam

Merged LDT-1415-pressures-monitoring-td

Options
4:53 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

4:36 pm

Vendor - TEL - Varshini Nagabooshanam

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
4:36 pm

Vendor - TEL - Varshini Nagabooshanam

Merge branch 'staging' into LDT-1415-pressures-monitoring-td

Options
    • -2
    • +3
    /MsgDefs.h
2:34 pm

Vendor - TEL - Varshini Nagabooshanam

Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

2:10 pm

Sean Nash

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, updated

Yes, updated

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:45 am

Sean Nash

Remove blank line.

Remove blank line.

11:43 am

Sean Nash

Looks like this reverted back.

Looks like this reverted back.

10:24 am

Vendor - TEL - Sameer Poyil

Fixed it

Fixed it

Tuesday 03 Feb
5:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

5:17 pm

Sean Nash

It is your comment, so please resolve it.

It is your comment, so please resolve it.

3:12 pm

Vendor - TEL - Sameer Poyil

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

2:04 pm

Vendor - TEL - Sameer Poyil

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

1:45 pm

Vendor - TEL - Sameer Poyil

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

1:02 pm

Vendor - TEL - Varshini Nagabooshanam

Monday 02 Feb
4:44 pm

Vendor - TEL - Sameer Poyil

input parameter not updated

input parameter not updated