dd-firmware / firmware

.settings

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 09 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 14 Nov
5:03 pm

Sean Nash

3:19 pm

Raghu Kallala , Vinayakam Mani and Dara Navaei

11:24 am

Dara Navaei

Done

Done

11:23 am

Dara Navaei

No I removed it.

No I removed it.

10:56 am

Sean Nash

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

Thursday 13 Nov
9:56 am

Michael Garthwaite

fixed. thanks

fixed. thanks

9:15 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should be a s...

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:14 am

Michael Garthwaite

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen. whether that should ...

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

9:09 am

Michael Garthwaite

fixed. thanks

fixed. thanks

Wednesday 12 Nov
10:28 pm

Sean Nash

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

Ok, but see my next comment below. Do we need to ACK with a result at all? Does TD require this?

3:23 pm

Michael Garthwaite

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

3:23 pm

Michael Garthwaite

updated to now change result to FALSE if we get a rr that is not NONE

updated to now change result to FALSE if we get a rr that is not NONE

1:51 pm

Michael Garthwaite

reworked to use the request stop functions in their respective op modes.

reworked to use the request stop functions in their respective op modes.

1:51 pm

Michael Garthwaite

reworked to use the request functions we have in the respective op modes. They check the standby constraint

reworked to use the request functions we have in the respective op modes. They check the standby constraint

1:50 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:50 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

1:50 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

11:20 am

Dara Navaei

Thursday 06 Nov
10:15 am

Vendor - TEL - Jashwant Gantyada

10:05 am

Sean Nash

Can we remove it now (before we merge to staging)?

Can we remove it now (before we merge to staging)?

10:04 am

Sean Nash

Is it still needed? If so, when do we expect it can be removed?

Is it still needed? If so, when do we expect it can be removed?

10:03 am

Sean Nash

If we're not sending ACK here, let's remove this code and replace with a comment stating we are only ACKing Dialin messages.

If we're not sending ACK here, let's remove this code and replace with a comment stating we are only ACKing Dialin messages.

10:01 am

Sean Nash

Is this necessary,?

Is this necessary,?

10:01 am

Sean Nash

What are we doing with fpReason?

What are we doing with fpReason?

10:00 am

Sean Nash

What are we doing with fpReason?

What are we doing with fpReason?

10:00 am

Sean Nash

Is sending of ACK msg needed here?

Is sending of ACK msg needed here?

9:51 am

Sean Nash

Is it appropriate to call for mode transition here? Better to signal the gen permeate unit (featured or de-featured) and let its state machine handle the transition back to standby mode.

Is it appropriate to call for mode transition here? Better to signal the gen permeate unit (featured or de-featured) and let its state machine handle the transition back to standby mode.

9:50 am

Sean Nash

Should we reject start request if we are not in standby mode? And is it appropriate to call for mode transition here? Better to signal Standby mode and let its state machine handle the transition.

Should we reject start request if we are not in standby mode?
And is it appropriate to call for mode transition here? Better to signal Standby mode and let its state machine handle the transition.

9:47 am

Sean Nash

Add blank line between declarations and function code.

Add blank line between declarations and function code.