leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 14
Total Committers: 18
Last Commit: 11 Aug
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Sean Nash

5 hrs ago

Vendor - TEL - Vijay Pamula

7 hrs ago

Sean Nash and Vendor - TEL - Arpita Srivastava

7 hrs ago

Sean Nash

Shouldn't this be in ModePostTreatment?

Shouldn't this be in ModePostTreatment?

7 hrs ago

Sean Nash

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

7 hrs ago

Sean Nash

Update this to work for all standby states w/ switch statement on given "new" state.

Update this to work for all standby states w/ switch statement on given "new" state.

7 hrs ago

Sean Nash

Why zeroes? Why not send TD version constants?

Why zeroes? Why not send TD version constants?

7 hrs ago

Sean Nash

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

Add parameter (disinfection cmd enum from DDDefs.h). Then only need one signal function for all disinfection types.

8 hrs ago

Sean Nash

change enum name too. need 1 alarm for each disinfection type.

change enum name too. need 1 alarm for each disinfection type.

8 hrs ago

Sean Nash

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

Just do one dd disinfect request msg with a command ID payload (from enum in DDDefs.h).

8 hrs ago

Sean Nash

Missing some disinfects.

Missing some disinfects.

8 hrs ago

Sean Nash

Move up after HCOL

Move up after HCOL

8 hrs ago

Vendor - TEL - Arpita Srivastava

Add to inputs : heparinSetupResumeRequested

Add to inputs : heparinSetupResumeRequested

8 hrs ago

Vendor - TEL - Arpita Srivastava

Add @alarm

Add @alarm

8 hrs ago

Vendor - TEL - Arpita Srivastava

Add to inputs : interruptedPreTxHeparinSetupState

Add to inputs : interruptedPreTxHeparinSetupState

Wednesday 12 Aug
3:59 pm

Sean Nash

Are we done testing? Can we remote test variables and code?

Are we done testing? Can we remote test variables and code?

3:29 pm

Vinayakam Mani

Remove Sequence step states if not being used.

Remove Sequence step states if not being used.

3:27 pm

Vinayakam Mani

Update comments ( remove start/end states)

Update comments ( remove start/end states)

3:26 pm

Vinayakam Mani

Update TD to DD.

Update TD to DD.

3:26 pm

Vinayakam Mani

Update alarm properties (DD fault, Priority eti,.)

Update alarm properties (DD fault, Priority eti,.)

3:23 pm

Vinayakam Mani

Remove the empty line.

Remove the empty line.

3:20 pm

Vinayakam Mani

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

Or User cancels drain request: To cancel the ongoing drain process. Could you please add the condition as well?

3:14 pm

Vinayakam Mani

Remove commented code.

Remove commented code.

3:14 pm

Vinayakam Mani

Remove D34 valve close.

Remove D34 valve close.

3:13 pm

Vinayakam Mani

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

Add a TODO comment that D83 will be updated to new valve once new valve driver added.

3:11 pm

Vinayakam Mani

void inside paranthesis.

void inside paranthesis.

3:01 pm

Vinayakam Mani

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that ...

You can remove the above condition and do the rest of code, except D65 valve opening. Initially this state was waiting for balancing chamber fill to be completed and open D65 valve later. Now that this function will check the condition and skip the valves actions if not met. this is not the expected behavior.

2:19 pm

Vinayakam Mani

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

It's better to keep AND condition that d66 pressure must come down to decay pressure before we start vent process.

2:15 pm

Vinayakam Mani

Open D80, not D85.

Open D80, not D85.

2:11 pm

Vinayakam Mani

Remove the commented code.

Remove the commented code.