ModeGenDialysate.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Done

Done

Done.

Done.

Same comment.

Same comment.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Input is d78TempAvgC

Input is d78TempAvgC

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Not sure these min/max are right here either.

Not sure these min/max are right here either.

Done.

Done.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Done.

Done.

Done.

Done.

Done.

Done.

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
done changed it.

done changed it.

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

Remove extra blank line.

Remove extra blank line.

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?