leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove the TODO comment.

Remove the TODO comment.

align the comment.

align the comment.

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

decays to threshold level (4 PSI).

decays to threshold level (4 PSI).

remove all commented code.

remove all commented code.

Update comment. remove TODO if no more applicable.

Update comment. remove TODO if no more applicable.

FillWaterEndState?

FillWaterEndState?

Delete it.

Delete it.

Supply state (instead of drain). Updates Inputs and outputs across the file.

Supply state (instead of drain). Updates Inputs and outputs across the file.

When the BC fill completed and allow opening D65 for Chamber F fill?

When the BC fill completed and allow opening D65 for Chamber F fill?

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

50ms?

50ms?

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before en...

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

Add comment to align with the rest of the implementation.

Add comment to align with the rest of the implementation.

Add outputs as well.

Add outputs as well.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)
I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmatio...

I don't see any change here. How does this function get called? I don't see the function being used anywhere - nobody is calling it. I think it should be called by Messaging.c when a UI confirmation msg is received.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

I thought we'd removed the first 3 states. Isn't install state the first state? Maybe Praneeth did that and it will show up when you merge staging into your branch.

171

171

Is this too early to tell DD to start? Ask Vinay.

Is this too early to tell DD to start? Ask Vinay.

Initialize post treatment too.

Initialize post treatment too.

Delete this. No treatment params mode in Leahi.

Delete this. No treatment params mode in Leahi.

Add blank line between declarations and code.

Add blank line between declarations and code.

I would keep this stuff commented out until disinfection is implemented.

I would keep this stuff commented out until disinfection is implemented.