leahi-common

TDDefs.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 12
Last Commit: 31 Dec 69
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
25 mins ago

Sean Nash

27 mins ago

Sean Nash

Align comment.

Align comment.

34 mins ago

Sean Nash

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

38 mins ago

Sean Nash

Should this line be un-commented?

Should this line be un-commented?

38 mins ago

Sean Nash

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

41 mins ago

Sean Nash

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

4 hrs ago

Vendor - TEL - Arpita Srivastava and Sean Nash

Monday 18 May
9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Sunday 17 May
11:46 pm

Sean Nash

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

11:37 pm

Sean Nash

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

Friday 15 May
9:52 am

Vendor - TEL - Varshini Nagabooshanam

I missed updating this earlier, I’ll push the updated code.

I missed updating this earlier, I’ll push the updated code.

9:19 am

Sean Nash

Can't have 3 values. Maximum 2 values allowed.

Can't have 3 values. Maximum 2 values allowed.

Thursday 14 May
9:48 am

Vendor - TEL - Arpita Srivastava

Looks like the description part should only be in the @param part. sysConfigTreatmentParameters should be an output? Input is None. Add @details for alarms

Looks like the description part should only be in the @param part.
sysConfigTreatmentParameters should be an output? Input is None.
Add @details for alarms

9:29 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

The Id name looks too long? What if we change Temperature to Temp?

The Id name looks too long? What if we change Temperature to Temp?

Wednesday 13 May
10:48 am

Vendor - TEL - Varshini Nagabooshanam

Removedd

Removedd

10:44 am

Vendor - TEL - Varshini Nagabooshanam

added

added

Tuesday 12 May
3:44 pm

Vendor - TEL - Arpita Srivastava

Please list names of variables in inputs and outputs. You can move any description in the brief section.

Please list names of variables in inputs and outputs.
You can move any description in the brief section.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment for this check and break the line in two lines.

Please add a comment for this check and break the line in two lines.

2:24 pm

Vendor - TEL - Arpita Srivastava

Please add a comment about this condition check. Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

Please add a comment about this condition check.

Move this part : ( fabs( request.ufRate - validatedUFRateLhr ) < NEARLY_ZERO ) ) to the next line.

2:18 pm

Vendor - TEL - Arpita Srivastava

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

Can we please align (move more towards right) the comments of this newly added section with the comments of existing sections?

2:00 pm

Vendor - TEL - Arpita Srivastava

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

Please keep on declaration of the variables in this section and move the initialization to initTreatmentParameters

1:59 pm

Vendor - TEL - Arpita Srivastava

Please rename this function to initTreatmentParameters

Please rename this function to initTreatmentParameters

1:58 pm

Vendor - TEL - Arpita Srivastava

We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

1:56 pm

Vendor - TEL - Arpita Srivastava

Even if you do not have an Output, please add the tag with None as the value. Please fix in other functions as well.

Even if you do not have an Output, please add the tag with None as the value.
Please fix in other functions as well.

1:54 pm

Vendor - TEL - Arpita Srivastava

Please indent the doxygen comments of all the functions, similar to existing functions.

Please indent the doxygen comments of all the functions, similar to existing functions.

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 11 May
5:41 pm

Vendor - TEL - Arpita Srivastava

origTreatmentParams should be an output?

origTreatmentParams should be an output?

5:25 pm

Vendor - TEL - Arpita Srivastava

Delete extra line

Delete extra line