dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 31
Total Committers: 17
Last Commit: 31 Dec 69
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Jun
1:30 pm

Vinayakam Mani

9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

7:12 am

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

We need to keep D64 opened after supply to maintain the supply to fbicarb flow filter

6:49 am

Vendor - TEL - Sameer Poyil

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again. we need to maintain the pressure balance in chamber F

in initial fill we are not closing D64, only in supply cycle, just before supply start, we close it and when supply end, we open it again.
we need to maintain the pressure balance in chamber F

6:45 am

Vendor - TEL - Sameer Poyil

will address it in new file created for mixing

will address it in new file created for mixing

Thursday 11 Jun
2:28 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
2:27 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -5
    • +5
    ./Controllers/SubstitutionPump.c
    • -4
    • +4
    ./Controllers/SubstitutionPump.h
    • -2
    • +2
    ./Monitors/Conductivity.c
    • -2
    • +2
    ./Monitors/Level.c
    • -2
    • +2
    ./Monitors/Temperature.c
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/FpgaDD.c
    • -1
    • +1
    ./Services/FpgaDD.h
    • -2
    • +2
    ./Services/Messaging.c
    • -2
    • +2
    ./Services/TDInterface.c
    • -2
    • +2
    ./Tasks/TaskPriority.c
2:24 pm

Michael Garthwaite

1:27 pm

Vinayakam Mani and Sean Nash

12:28 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -13
    • +5
    ./Controllers/SubstitutionPump.c
10:10 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -4
    • +6
    ./Controllers/SubstitutionPump.c
    • -1
    • +1
    ./Services/Messaging.c
10:08 am

Michael Garthwaite

fixed thanks

fixed thanks

10:00 am

Sean Nash

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

9:59 am

Michael Garthwaite

fixed thanks

fixed thanks

9:59 am

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

9:58 am

Michael Garthwaite

fixed thanks

fixed thanks

9:58 am

Michael Garthwaite

LDT-4001: code review updates

Options
    • -3
    • +3
    ./Controllers/SubstitutionPump.c
9:57 am

Michael Garthwaite

this is a set speed in rpm

this is a set speed in rpm

9:57 am

Michael Garthwaite

this is speed in rpm

this is speed in rpm

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:55 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -13
    • +13
    ./Controllers/SubstitutionPump.c
    • -2
    • +2
    ./Controllers/SubstitutionPump.h
    • -1
    • +1
    ./Services/Messaging.c
    • -3
    • +3
    ./Services/TDInterface.c
9:50 am

Michael Garthwaite

LDT-4001: code review updates

Options
    • -3
    • +4
    ./Controllers/SubstitutionPump.c
    • -1
    • +1
    ./Controllers/SubstitutionPump.h
9:43 am

Sean Nash

Change speed to rate.

Change speed to rate.

9:43 am

Sean Nash

pumpTargetRate

pumpTargetRate

9:43 am

Sean Nash

Change function name to say rate instead of speed

Change function name to say rate instead of speed