Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

Space after 0

Space after 0

prevDryBicartState

prevDryBicartState

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

prevBalChamberState?

prevBalChamberState?

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Remove blank line.

Remove blank line.

I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

Update name.

Update name.

Add a Todo comment to resolve the issue.

Add a Todo comment to resolve the issue.

Align the indentation.

Align the indentation.

Align the indentation.

Align the indentation.

Do we need these comments? delete it if not required.

Do we need these comments? delete it if not required.

Align the indent

Align the indent

Remove empty line

Remove empty line

Remove unused header files.

Remove unused header files.

Remove empty line.

Remove empty line.

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

Remove the blank line

Remove the blank line

Add headers for all below functions.

Add headers for all below functions.

Rmove extra blank line

Rmove extra blank line