Activity leahi-dialin/leahi_dialin/utils/__init_

10:06 am

Michael Garthwaite

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( ...

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

10:02 am

Sean Nash

More
LEAHI-DIALIN-LDT-2655-1
resumed reviewing

2:03 pm

Michael Garthwaite

More
20c66b3
changed 7 files
LDT-2655-fix_conductivity_override, develop LEAHI-DIALIN-LDT-2655-1

Merge branch 'staging' into LDT-2655-fix_conductivity_override

- -1
- +1
./__init__.py
- History
- Source
- Diff
./__init__.py
… 6 more files in changeset.

12:46 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-2655-1
joined review

12:46 pm

Dara Navaei

4:51 pm

Zoltan Miskolci

4:38 pm

Zoltan Miskolci

More
3715028
changed 13 files
develop

Merge branch 'LDT-2998-update-dialin-to-support-any-b1' into develop

- -1
- +1
./__init__.py
- History
- Source
- Diff
./__init__.py
… 12 more files in changeset.

4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

More
LEAHI-DIALIN-LDT-2998-1
finished reviewing

3:18 pm

Michael Garthwaite

More
LEAHI-DIALIN-LDT-2998-1
resumed reviewing

1:57 pm

Zoltan Miskolci

More
8ad78a5
changed 7 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1394-blood-flow-rate-overide-request and 32 more LEAHI-DIALIN-LDT-2998-1 LEAHI-DIALIN-LDT-2655-1

- Added D85 Valve - Removed error message during init as it's not an error

- -1
- +1
./__init__.py
- History
- Source
- Diff
./__init__.py
… 6 more files in changeset.

10:33 am

Zoltan Miskolci

Merged FP into DD test configs

10:33 am

Zoltan Miskolci

Renamed

9:34 am

Zoltan Miskolci

Fixed

9:34 am

Zoltan Miskolci

Added enum to FP and TD Configs.

9:28 am

Zoltan Miskolci

Vinayakam Mani What is the advantage of doing that? If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository wh...

Vinayakam Mani What is the advantage of doing that?
If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository when starting with 2.0.
While I use a more generic flag, I won't need to do that. So just using a better name I am sparing myself hours of work in the future.

11:47 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-2998-1
commented on review

You may use the same test configs from DD here, to set the relevant test configs from FP Dialin.

11:35 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-2998-1
commented on review

POS_FIELD_3??

11:34 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-2998-1
commented on review

Please follow the same naming convention as firmware enums.

11:02 am

Sean Nash

Understand. In this case, the spare positions correspond to bit positions in the FPGA register and the new valves took the 1, 2, and 6 spots.

11:01 am

Zoltan Miskolci

Fixed Typo

10:57 am

Zoltan Miskolci

Ok (But feels weird to start the counting of existing items from 0 if that's the spare3 instead of 1. Calling the D79 the "zeroeth" spare valve instead of the first spare valve... Personally I thin...

Ok
(But feels weird to start the counting of existing items from 0 if that's the spare3 instead of 1. Calling the D79 the "zeroeth" spare valve instead of the first spare valve... Personally I think we should name them Spare1-8 instead of Spare 0-7)

10:23 am