leahi-dialin / leahi_dialin / dd / modules

levels.py

Clone Tools

Stats

Commits this week: 3
Total Committers: 5
Last Commit: 31 Dec 69
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

1 hr ago

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

1 hr ago

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

2 hrs ago

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

2 hrs ago

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Wednesday 28 Jan
9:22 am

Dara Navaei

9:17 am

Raghu Kallala

9:09 am

Zoltan Miskolci

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the in...

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the init process and to not have confusing messages

9:00 am

Raghu Kallala

why are we passing this exception?

why are we passing this exception?

Tuesday 27 Jan
1:49 pm

Vinayakam Mani

1:47 pm

Vinayakam Mani

1:32 pm

Zoltan Miskolci

merged

merged

1:32 pm

Zoltan Miskolci

renamed

renamed

1:32 pm

Zoltan Miskolci

renamed

renamed

1:32 pm

Zoltan Miskolci

Updated based on FW

Updated based on FW

1:19 pm

Raghu Kallala

Here is the latest list from fw TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0, ///< Test configuration DD & FP enable Beta 1.0 hardware TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW, ///< Te...

Here is the latest list from fw

TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0, ///< Test configuration DD & FP enable Beta 1.0 hardware
TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW, ///< Test configuration first configuration.
TEST_CONFIG_DD_DISABLE_BC_PRESSURE_ALARMS, ///< Test configuration DD disabling BC pressure alarms
TEST_CONFIG_DD_ENABLE_DRY_BICARB, ///< Test configuration DD to use dry bicarb
TEST_CONFIG_DD_ENABLE_4WIRE_RINSE_PUMP, ///< Test configuration DD enable 4-wire rinse pump.
TEST_CONFIG_FP_SKIP_PRE_GEN_FLUSH, ///< Test configuration FP skip pre-gen flush
TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP, ///< Test configuration to use diener 1000 pump for D48
TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL, ///< Test configuration to switch to PWM control for D79
TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL, ///< Test configuration DD enable spent chamber H fill
TEST_CONFIG_DD_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable DD conductivity alarms
TEST_CONFIG_FP_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable FP conductivity alarms
TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL, ///< Test configuration to switch to open loop control for concentrate dosing
TEST_CONFIG_DD_ENABLE_UF_TEMP_COMPENSATION, ///< Test configuration for enabling UF temperature compensation
NUM_OF_TEST_CONFIGS ///< Number of test configuration.

11:49 am

Vinayakam Mani

Please sync all of these with Firmware order of definitions.

Please sync all of these with Firmware order of definitions.

11:48 am

Vinayakam Mani

TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP. by default, temp compensation is disabled.

TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP. by default, temp compensation is disabled.

11:43 am

Vinayakam Mani

TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL

TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL

11:41 am

Vinayakam Mani

ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB => we can use only one of these. We can keep test config 2 ( may rename as ENABLE_DRY_BICARB) and 8 can be deleted.

ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB => we can use only one of these. We can keep test config 2 ( may rename as ENABLE_DRY_BICARB) and 8 can be deleted.

11:40 am

Zoltan Miskolci

updated

updated

11:40 am

Zoltan Miskolci

updated, thanks for the confirmation

updated, thanks for the confirmation