leahi-dialin / leahi_dialin / fp / modules

temperatures.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 6
Last Commit: 31 Dec 69
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Michael Garthwaite

Monday 26 Jan
4:51 pm

Zoltan Miskolci

4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Friday 23 Jan
3:18 pm

Michael Garthwaite

11:42 am

Zoltan Miskolci

- Removed HW flag from broadcast as FW doesn't change broadcast content based on HW flag

Options
    • -4
    • +3
    ./temperatures.py
  2. … 6 more files in changeset.
Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -55
    • +27
    ./temperatures.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
12:35 pm

Sean Nash

12:22 pm

Zoltan Miskolci

12:22 pm

Zoltan Miskolci

Merge branch 'LDT-2980' into staging

Options
    • -1
    • +1
    ./temperatures.py
11:08 am

Zoltan Miskolci

11:03 am

Zoltan Miskolci

Merge branch 'LDT-611-fp-add-ability-to-override-tempe' into staging

Options
    • -50
    • +50
    ./temperatures.py
  2. … 4 more files in changeset.
10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

8:58 am

Sean Nash , Michael Garthwaite and Raghu Kallala

8:35 am

Zoltan Miskolci

Updated

Updated

Tuesday 20 Jan
4:58 pm

Zoltan Miskolci

Updated override range for flow sensors

Options
    • -1
    • +1
    ./temperatures.py
3:33 pm

Tiffany Mejia

2:29 pm

Zoltan Miskolci

I didn't added any code for override. I also can't stop anyone to send in an override command with random numbers. The allowing of override should be on the FW part, where sending the override with...

I didn't added any code for override.
I also can't stop anyone to send in an override command with random numbers.
The allowing of override should be on the FW part, where sending the override with (sensor_id, value, no reset) should return false for those that are not accepted.

11:00 am

Raghu Kallala

We should not allow overrides for newly added internal temperatures

We should not allow overrides for newly added internal temperatures

10:47 am

Zoltan Miskolci

LDT-2980 - Added internal temperature for flow sensors

Options
    • -1
    • +9
    ./temperatures.py
  2. … 1 more file in changeset.
10:42 am

Zoltan Miskolci

10:41 am

Zoltan Miskolci

LDT-2980 - Added Internal temperature for flow sensors

Options
    • -1
    • +9
    ./temperatures.py
  2. … 1 more file in changeset.
10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

9:31 am

Zoltan Miskolci

- Renamed variable

Options
    • -2
    • +2
    ./temperatures.py
  2. … 9 more files in changeset.
9:04 am

Dara Navaei

LEAHI-DIALIN-LDT-2980_Request: add ability to get the flowmeter measured internal temperature
LEAHI-DIALIN-LDT-2980_Request: add ability to get the flowmeter measured internal temperature
Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).

10:46 am

Zoltan Miskolci

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how...

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how much to shift value for it.
Making an alias is more dynamic and not needing separate variables to be maintained for this.