leahi-dialin / leahi_dialin / fp

filtration_purification.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 31 Dec 69
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 22 Jan
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -111
    • +68
    ./filtration_purification.py
  2. … 46 more files in changeset.
Wednesday 21 Jan
12:39 pm

Zoltan Miskolci

12:38 pm

Zoltan Miskolci

Merge branch 'LDT-3159-getter_for_fp_defeatured' into staging

Options
    • -14
    • +61
    ./filtration_purification.py
  2. … 1 more file in changeset.
12:35 pm

Sean Nash

12:32 pm

Sean Nash and Raghu Kallala

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

8:42 am

Raghu Kallala

8:42 am

Raghu Kallala

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:28 am

Michael Garthwaite

10:21 am

Zoltan Miskolci

Renamed

Renamed

10:21 am

Zoltan Miskolci

Moved it into login request

Moved it into login request

10:20 am

Zoltan Miskolci

- Renamed command - Moved command from init to log in (as login is neccessary for it)

Options
    • -2
    • +2
    ./filtration_purification.py
10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
12:26 pm

Michael Garthwaite

This will always return 0 and delay init from completing by up to 0.5s as the user is not logged in at the time of init.

This will always return 0 and delay init from completing by up to 0.5s as the user is not logged in at the time of init.

12:25 pm

Michael Garthwaite

The naming of this method is misleading as it sends the message to request defeatured status and it is retrieved in a separate callback. The 'get' implies that the value returned from this method i...

The naming of this method is misleading as it sends the message to request defeatured status and it is retrieved in a separate callback. The 'get' implies that the value returned from this method is the defeatured status. The value returned is not the defeatured status but rather a T/F condition on if the FW replied back to dialin successfully.

suggestion: cmd_request_defeatured_status()

11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).

10:49 am

Zoltan Miskolci

That's how it's called in the FW, I just copied it. But yes, I suspect the Def is short for defeatured.

That's how it's called in the FW, I just copied it.
But yes, I suspect the Def is short for defeatured.

10:46 am

Zoltan Miskolci

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how...

I am not sure I can assign unique to the dynamic enums. Also with unique you can't add aliases and some(for example: temperature) overrides use the aliases to determine which msg id to call and how much to shift value for it.
Making an alias is more dynamic and not needing separate variables to be maintained for this.

10:42 am

Zoltan Miskolci

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation. Making it dynamic makes it that when the beta test ...

Enum content of Beta 1.0 and Beta 1.9 is different. The new sensors messing up the order for the old HW's override and broadcast data allocation.
Making it dynamic makes it that when the beta test config is called the enums are switching content to reflect that.

10:40 am

Zoltan Miskolci

Reasons: *No one should interact with it or be aware of it's existence, so the name shouldn't matter. *As we only have 2 version in test at the same time, I am making an internal variable name th...

Reasons:

  • No one should interact with it or be aware of it's existence, so the name shouldn't matter.
  • As we only have 2 version in test at the same time, I am making an internal variable name that I don't need to rename every 3 months or so.
    Needing to make a review smaller with editing less thing makes it faster to be completed...


In case a situation arrives when we will test more version at the same time Alpha, Beta, Beta 1.9, it will require a redesign on the part of enum generation too.

10:39 am

Michael Garthwaite

previously we had the unique keyword above our classes as a developer sanity check to ensure the dev didnt duplicate values in the dict since we dont auto generate this defs. if i remember correct...

previously we had the unique keyword above our classes as a developer sanity check to ensure the dev didnt duplicate values in the dict since we dont auto generate this defs.

if i remember correctly, unique is checked when the enum class is imported. We test it our unit tests, both test_constructors and test_imports.

The reason we currently would want to keep unique is because the DialinEnum class has the method has_value(). Without knowing the current usage of this function from our users, it will impact users expected behavior.

My question to you: Should we continue to test and check how the defs for duplicates?

10:19 am

Michael Garthwaite

This should be renamed to be more concise and allow flexibility as more HW revisions come. What is next gen? All BETAs? BETA 1.9? Beta 2.0? DVT?

This should be renamed to be more concise and allow flexibility as more HW revisions come. What is next gen? All BETAs? BETA 1.9? Beta 2.0? DVT?

10:16 am

Michael Garthwaite

What is the intention of making our defs dynamic and a class object rather keeping it a class?

What is the intention of making our defs dynamic and a class object rather keeping it a class?

9:47 am

Zoltan Miskolci

Based on it's code, doesn't look like it. That's why I removed the publish to not mislead.

Based on it's code, doesn't look like it. That's why I removed the publish to not mislead.