Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I don't think this is needed as the FW handles the floater sensors separately with 2 separate enums, instead of merging them like the others. So you don't need to create an offset for override when...

I don't think this is needed as the FW handles the floater sensors separately with 2 separate enums, instead of merging them like the others.
So you don't need to create an offset for override when you want to override the FP level sensors.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

LEVEL_OFFSET?

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
Typo, response

Typo, response

Typo, response

Typo, response

Fix the header

Fix the header

LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( ...

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

removed

removed

Remove this extra line

Remove this extra line

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables