leahi-dialin / leahi_dialin / common

msg_ids.py

Clone Tools

Stats

Commits this week: 12
Total Committers: 14
Last Commit: 31 Dec 69
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 01 May
9:11 am

Zoltan Miskolci

It's present in fp_defs as FPRecoveryOptions

It's present in fp_defs as FPRecoveryOptions

9:08 am

Zoltan Miskolci

Update the header docc please

Update the header docc please

9:08 am

Zoltan Miskolci

DD Substitution Pump

DD Substitution Pump

9:07 am

Zoltan Miskolci

It's not really a start / stop command, when you are setting the speed.

It's not really a start / stop command, when you are setting the speed.

9:05 am

Zoltan Miskolci

shouldn't this be "msg_id_dd_substitution_pump_data"?

shouldn't this be "msg_id_dd_substitution_pump_data"?

Thursday 30 Apr
2:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
2:23 pm

Vendor - TEL - Sameer Poyil

10:27 am

Sean Nash

9:01 am

Dara Navaei

LEAHI-DIALIN-LDT-4193_NON-FEATURE: SW Misc & Enhc - SW - 01 - Water/Dialysate Sample - R&I
LEAHI-DIALIN-LDT-4193_NON-FEATURE: SW Misc & Enhc - SW - 01 - Water/Dialysate Sample - R&I
Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

Sunday 26 Apr
2:46 pm

Sean Nash

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

12:22 pm

Sean Nash

Thursday 23 Apr
11:08 am

Dara Navaei

LEAHI-DIALIN-LDT-4161_Post-Treatment - SW - 01 - TxReview - R&I
LEAHI-DIALIN-LDT-4161_Post-Treatment - SW - 01 - TxReview - R&I
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Friday 17 Apr
3:05 pm

Nicholas Ramirez

12:26 pm

Tiffany Mejia and Behrouz NematiPour

12:08 pm

Behrouz NematiPour

12:07 pm

Tiffany Mejia

12:07 pm

Behrouz NematiPour

Wednesday 15 Apr
6:18 pm

Sean Nash

12:26 pm

Stephen Quong

10:27 am

Behrouz NematiPour and Nicholas Ramirez

Tuesday 14 Apr
4:18 pm

Dara Navaei

LEAHI-DIALIN-LDT-3932_Post-Treatment - SW - 01 - Foundation - R&I
LEAHI-DIALIN-LDT-3932_Post-Treatment - SW - 01 - Foundation - R&I
Friday 10 Apr
10:27 am

Sean Nash

Wednesday 08 Apr
11:26 am

Zoltan Miskolci