leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done.

Done.

Done

Done

Done.

Done.

Same comment.

Same comment.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Input is d78TempAvgC

Input is d78TempAvgC

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Not sure these min/max are right here either.

Not sure these min/max are right here either.

Done.

Done.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Reverse order of comparison

Reverse order of comparison

Reverse order of comparison.

Reverse order of comparison.

Reverse order of comparison.

Reverse order of comparison.

Reverse order of comparison.

Reverse order of comparison.

Done.

Done.

Algin "=" to be consistent with those below.

Algin "=" to be consistent with those below.

Add blank line after declarations.

Add blank line after declarations.

Add blank line after declarations.

Add blank line after declarations.

Align comment.

Align comment.

Is it time to restore?

Is it time to restore?

Remove extra space after "=".

Remove extra space after "=".