Activity leahi-dialin/leahi_dialin/common/msg

Zoltan and I had a meeting, and the counter solution he provided works better than mine. He explained to me that my proposed solution has flaws. RESOLVED.

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

11:45 am

Tiffany Mejia and Michael Garthwaite

More
LEAHI-DIALIN-LDT-4872-1
finished reviewing

3:08 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

12:55 pm

Sean Nash

More
LEAHI-DIALIN-LDT-4072-1
finished reviewing

3:39 pm

Behrouz NematiPour and Stephen Quong

More
LEAHI-DIALIN-LDT-4787-1
finished reviewing

3:36 pm

Vinayakam Mani

More
LEAHI-DIALIN-LDT-4160-1
finished reviewing

3:02 pm

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility. 1. The conversion module's bytearray to value methods work, but th...

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.

Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed

12:33 pm

Behrouz NematiPour

RESOLVED for now.

12:32 pm

Behrouz NematiPour

I would not do that because the function names and messages for each project should be different to avoid confusion. I think that is fine for now. RESOLVED.

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

msg_ids.py

Stats

Commits this week: 3

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Behrouz NematiPour

Nicholas Ramirez

Nicholas Ramirez

Dara Navaei

Sean Nash

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

Dara Navaei

Vendor - TEL - Arpita Srivastava

Raghu Kallala

Dara Navaei

Dara Navaei

Sean Nash

Tiffany Mejia and Michael Garthwaite

Zoltan Miskolci

Dara Navaei

Behrouz NematiPour

Tiffany Mejia and Michael Garthwaite

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Sean Nash

Nicholas Ramirez

Behrouz NematiPour and Stephen Quong

Nicholas Ramirez

Vinayakam Mani

Zoltan Miskolci

Behrouz NematiPour

Behrouz NematiPour